Page MenuHomeFreeBSD
Differential D33244

pfsync: fix incorrect enabling of defer mode
ClosedPublic
Actions

Authored by kp on Dec 3 2021, 9:49 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 6, 4:15 PM
Unknown Object (File)
Thu, Mar 5, 7:13 PM
Unknown Object (File)
Tue, Mar 3, 4:25 PM
Unknown Object (File)
Tue, Mar 3, 1:22 PM
Unknown Object (File)
Fri, Feb 27, 7:42 PM
Unknown Object (File)
Tue, Feb 24, 3:06 PM
Unknown Object (File)
Thu, Feb 19, 4:23 PM
Unknown Object (File)
Sat, Feb 7, 8:31 PM
View All Files
Subscribers
farrokhi
glebius
imp
melifaro

Details

Reviewers
glebius
Group Reviewers
network
pfsense
Commits
rGc36006be5424: pfsync: fix incorrect enabling of defer mode
rG3836400a785f: pfsync: fix incorrect enabling of defer mode
rG73fd0eaf5930: pfsync: fix incorrect enabling of defer mode
Summary

When we exposed the PFSYNCF_OK flag to userspace in 5f5bf88949d we
unintentionally caused defer mode to always be enabled.
The ioctl check only looked for nonzero, not for the PFSYNCF_DEFER flag.

Fix this check and ensure ifconfig sets the flag.

MFC after: 1 week
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 43119
Build 40007: arc lint + arc unit

Revision Contents
Changeset List

PathSize
sbin/
ifconfig/
2 lines
sys/
netpfil/
pf/
2 lines

Diff 99391

View Options

sbin/ifconfig/ifpfsync.c

Loading...
View Options

sys/netpfil/pf/if_pfsync.c

Loading...