Page MenuHomeFreeBSD

dummynet: Avoid an out-of-bounds read in do_config()
ClosedPublic

Authored by markj on Nov 26 2021, 4:01 PM.
Tags
None
Referenced Files
F108514238: D33132.id99170.diff
Sat, Jan 25, 7:35 PM
Unknown Object (File)
Fri, Jan 24, 2:24 AM
Unknown Object (File)
Sat, Jan 18, 5:31 PM
Unknown Object (File)
Sat, Jan 11, 7:51 AM
Unknown Object (File)
Sat, Jan 11, 7:01 AM
Unknown Object (File)
Sat, Jan 11, 4:39 AM
Unknown Object (File)
Dec 5 2024, 4:33 AM
Unknown Object (File)
Nov 15 2024, 10:01 AM

Details

Summary

do_config() processes a buffer of variable-length dummynet commands.
The loop which processes this buffer loads the fixed-length header
before checking whether there are any bytes left to read, so it performs
a 4-byte read past the end of the buffer before terminating.

Restructure the loop to avoid this.

Reported by: Jenkins (KASAN job)
MFC after: 1 week
Sponsored by: The FreeBSD Foundation

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable