Page MenuHomeFreeBSD

dummynet: Avoid an out-of-bounds read in do_config()
ClosedPublic

Authored by markj on Nov 26 2021, 4:01 PM.
Tags
None
Referenced Files
F165899885: D33132.diff
Mon, Aug 10, 10:52 AM
Unknown Object (File)
Sun, Aug 9, 5:40 PM
Unknown Object (File)
Fri, Aug 7, 6:53 PM
Unknown Object (File)
Thu, Aug 6, 6:25 PM
Unknown Object (File)
Tue, Jul 21, 1:31 PM
Unknown Object (File)
Mon, Jul 20, 3:12 AM
Unknown Object (File)
Sat, Jul 18, 11:57 AM
Unknown Object (File)
Sun, Jul 12, 4:18 PM

Details

Summary

do_config() processes a buffer of variable-length dummynet commands.
The loop which processes this buffer loads the fixed-length header
before checking whether there are any bytes left to read, so it performs
a 4-byte read past the end of the buffer before terminating.

Restructure the loop to avoid this.

Reported by: Jenkins (KASAN job)
MFC after: 1 week
Sponsored by: The FreeBSD Foundation

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable