Page MenuHomeFreeBSD

dummynet: Avoid an out-of-bounds read in do_config()
ClosedPublic

Authored by markj on Nov 26 2021, 4:01 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 24, 8:57 AM
Unknown Object (File)
Tue, Apr 21, 10:01 PM
Unknown Object (File)
Tue, Apr 21, 8:32 AM
Unknown Object (File)
Wed, Apr 15, 10:43 AM
Unknown Object (File)
Sun, Apr 12, 11:25 AM
Unknown Object (File)
Sun, Apr 12, 12:20 AM
Unknown Object (File)
Sat, Apr 11, 11:37 AM
Unknown Object (File)
Fri, Apr 10, 1:44 AM

Details

Summary

do_config() processes a buffer of variable-length dummynet commands.
The loop which processes this buffer loads the fixed-length header
before checking whether there are any bytes left to read, so it performs
a 4-byte read past the end of the buffer before terminating.

Restructure the loop to avoid this.

Reported by: Jenkins (KASAN job)
MFC after: 1 week
Sponsored by: The FreeBSD Foundation

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable