Page MenuHomeFreeBSD

dummynet: Avoid an out-of-bounds read in do_config()
ClosedPublic

Authored by markj on Nov 26 2021, 4:01 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Sep 30, 9:01 AM
Unknown Object (File)
Fri, Sep 25, 12:50 AM
Unknown Object (File)
Fri, Sep 25, 12:49 AM
Unknown Object (File)
Fri, Sep 25, 12:47 AM
Unknown Object (File)
Thu, Sep 10, 10:28 PM
Unknown Object (File)
Thu, Sep 10, 8:10 PM
Unknown Object (File)
Sun, Sep 6, 10:51 AM
Unknown Object (File)
Sun, Sep 6, 6:39 AM

Details

Summary

do_config() processes a buffer of variable-length dummynet commands.
The loop which processes this buffer loads the fixed-length header
before checking whether there are any bytes left to read, so it performs
a 4-byte read past the end of the buffer before terminating.

Restructure the loop to avoid this.

Reported by: Jenkins (KASAN job)
MFC after: 1 week
Sponsored by: The FreeBSD Foundation

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 42981
Build 39869: arc lint + arc unit