Paths

Table of Contentst

devel/tex-synctex: Update to 1.21.0
AbandonedPublic
Actions

Authored by kfv_kfv.io on Oct 1 2021, 6:40 PM.

Details

Reviewers

hrs
koobs
bofh
tcberner
trond.endrestol_ximalas.info

Group Reviewers

Contributor Reviewers (ports)
Ports Committers

Summary

devel/tex-synctex: Update to 1.21.0

- Remove various patches to improve and ease maintenance by bringing them
  together and excluding unnecessary components directly in the Makefile patch
  from their corresponding macros. Couldn't think of a better way, especially
  since we're using the original TeX Live codebase to extract and build the SyncTeX
  component separately.
- Add synctex_version.h header.

Reviewed_by: koobs, ??
Approved by: 
Differential_Revision: D32264

Dependant ports editors/texworks and graphics/zathura are updated in
in D32265 and D32266, respectively. PORTREVISION of editors/gummi,
net-mgmt/netmagis-www, and print/texlive-full are also incremented. For
texlive-full, though, I am not sure if I've done it correctly.

In the meanwhile, as explained above, old patchfiles are deleted as I've
brought configuration arguments into the main Makefile. This way, we can
maintain the port more easily in future.

Test Plan

portlint: passed
testport: passed
runtime: I used it for days on FreeBSD 13.0-RELEASE

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 42866
Build 39754: arc lint + arc unit

Event Timeline

kfv_kfv.io created this revision.Oct 1 2021, 6:40 PM

Herald added a subscriber: mat. · View Herald TranscriptOct 1 2021, 6:40 PM

kfv_kfv.io requested review of this revision.Oct 1 2021, 6:40 PM

Harbormaster completed remote builds in B41898: Diff 96097.Oct 1 2021, 6:40 PM

kfv_kfv.io edited the summary of this revision. (Show Details)Oct 1 2021, 6:42 PM

kfv_kfv.io mentioned this in D32265: editors/texworks: Update to 0.6.7.Oct 1 2021, 7:04 PM

kfv_kfv.io edited the summary of this revision. (Show Details)Oct 1 2021, 7:06 PM

kfv_kfv.io mentioned this in D32266: graphics/zathura: Update to 0.4.8, Add SyncTeX support.Oct 1 2021, 7:16 PM

kfv_kfv.io added a reviewer: koobs.Nov 1 2021, 11:07 PM

koobs edited the summary of this revision. (Show Details)Nov 18 2021, 1:22 AM

koobs edited the test plan for this revision. (Show Details)

koobs added a reviewer: Contributor Reviewers (ports).

as this change doesn't affect them to my understandings,

I'm under the impression bumping shared library major versions requires bumping dependents. In what sense does this major version change not affect them?

Do any other tex ports require updating in tandem with this? I'm under the impression all ports are usually updated as a set, or are they individually update'able?

Add QA confirmation to TEST PLAN section

devel/tex-synctex/Makefile
22–28	Can you explain the why for this change chunk please (in the differential summary)
27–50	Can you explain the why for this change chunk please (in the differential summary)
devel/tex-synctex/files/patch-Makefile.in
1–16	Add patch header comment explaining the why (rationale) for this change. Include any upstream reference links (issues, pr's, commits) where applicable

This revision now requires changes to proceed.Nov 18 2021, 1:28 AM

Also, explain files/patch-* removal (upstreamed? something else?) in the differential SUMMARY

I'm under the impression bumping shared library major versions requires bumping dependents. In what sense does this major version change not affect them?

True, my apologies. I'll take care of them.

Also, explain files/patch-* removal (upstreamed? something else?) in the differential SUMMARY

Sure, roger that.

Fix portlint errors
Update PORTREVISION of dependant ports

Harbormaster completed remote builds in B42865: Diff 98688.Nov 18 2021, 11:31 AM

kfv_kfv.io edited the summary of this revision. (Show Details)Nov 18 2021, 11:35 AM

kfv_kfv.io edited the test plan for this revision. (Show Details)

kfv_kfv.io edited the test plan for this revision. (Show Details)Nov 18 2021, 2:37 PM

Both portlint and poudriere testport successfully passed.

Add PORTREVISION for print/texlive-full

Harbormaster completed remote builds in B42866: Diff 98693.Nov 18 2021, 3:06 PM

kfv_kfv.io edited the summary of this revision. (Show Details)Nov 18 2021, 3:12 PM

kfv_kfv.io marked an inline comment as done.

kfv_kfv.io marked an inline comment as done.Nov 18 2021, 3:22 PM

kfv_kfv.io added inline comments.

devel/tex-synctex/files/patch-Makefile.in
1–16	The SyncTeX project is part of the TeXLive project and is separated from devel/tex-web2c to devel/tex-synctex in rP392909. The patch makes sure no other component is built, tested, or installed since only SyncTeX utility and its libraries are required.

Document the patchfile

Harbormaster completed remote builds in B42867: Diff 98696.Nov 18 2021, 3:35 PM

koobs requested changes to this revision.Jan 2 2022, 12:39 AM

koobs added inline comments.

devel/tex-synctex/Makefile
22–50	Explain these changes in the commit log message (in the formatted section). Something like: - Disable all optional dependencies in CONFIGURE_ARGS so they're never auto-detected Or similar
devel/tex-synctex/files/patch-Makefile.in
9	Are there any dynamic/configure or build methods to disable installation of 'EXTRA_PROGRAMS' without patching it out here? Note also: commit log summaries should include 'rationale' for changes too, like this one (we we patched it out versus another way), like: - Patch out EXTRA_PROGRAMS. There's no dynamic method to disable these at present'

This revision now requires changes to proceed.Jan 2 2022, 12:39 AM

@koobs: Done. Let me know if there's anything left. Thank you so much.

kfv_kfv.io requested review of this revision.Feb 7 2022, 11:09 PM

kfv_kfv.io added a reviewer: Ports Committers.Apr 7 2022, 11:35 AM

Loop in people involved in recent text update

Include a note in commit log message that you're bumping dependent ports PORTREVISIONS due to shared library major version increase

This revision is now accepted and ready to land.Apr 8 2022, 2:07 AM

I am sorry that I might have missed this review while I have upgraded the entire tex ecosystem to the 20210324 version and currently tex-synctex is at 2.0.0. So the entire patch needs a patch refresh.

This revision now requires changes to proceed.Apr 8 2022, 7:35 AM

@bofh: Perfect! Sorry that I didn't notice the update. All right, so I close this revision, thanks.

kfv_kfv.io abandoned this revision.Apr 8 2022, 10:44 AM