All timers keep inpcb locked through their execution. We need to
check these flags only once. Checking for INP_TIMEWAIT earlier is
is also safer, since such inpcbs point into tcptw rather than tcpcb,
and any dereferences of inp_ppcb as tcpcb are erroneous.
Details
Details
- Reviewers
• hselasky jch rrs - Group Reviewers
transport - Commits
- rG9a06a8245548: tcp_timers: check for (INP_TIMEWAIT | INP_DROPPED) only once
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 42759 Build 39647: arc lint + arc unit
Event Timeline
Comment Actions
This check is occurring lots of places and could have been factored out:
if (inp->inp_flags & (INP_TIMEWAIT | INP_DROPPED)) {
INP_WUNLOCK(inp);