tcp_timewait: use on stack struct tcptw as last resort
ClosedPublic
Actions

Authored by glebius on Nov 12 2021, 5:11 PM.

Details

Reviewers

Group Reviewers

Commits

rGff94500855c1: Add tcp_freecb() - single place to free tcpcb.
rGfb8588d2cb44: tcp_timewait: use on stack struct tcptw as last resort

Summary

In case we failed to uma_zalloc() and also failed to reuse with
tcp_tw_2msl_scan(), then just use on stack tcptw. This will allow
to run through tcp_twrespond() and standard tcpcb discard routine.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

glebius created this revision.Nov 12 2021, 5:11 PM

Herald added a reviewer: transport. · View Herald TranscriptNov 12 2021, 5:11 PM

Herald added subscribers: melifaro, imp. · View Herald Transcript

Harbormaster completed remote builds in B42757: Diff 98428.Nov 12 2021, 5:11 PM

glebius requested review of this revision.Nov 12 2021, 5:11 PM

glebius added a child revision: D32966: Add tcp_freecb() - single place to free tcpcb..

rrs accepted this revision.Nov 17 2021, 7:44 PM

This revision is now accepted and ready to land.Nov 17 2021, 7:44 PM

Closed by commit rGfb8588d2cb44: tcp_timewait: use on stack struct tcptw as last resort (authored by glebius). · Explain WhyNov 19 2021, 4:28 AM

This revision was automatically updated to reflect the committed changes.

glebius added a commit: rGfb8588d2cb44: tcp_timewait: use on stack struct tcptw as last resort.

glebius added a commit: rGff94500855c1: Add tcp_freecb() - single place to free tcpcb..

Revision Contents
Changeset List

Path

Size

sys/

netinet/

tcp_timewait.c

9 lines

Diff 98722

View Options

sys/netinet/tcp_timewait.c

tcp_timewait: use on stack struct tcptw as last resortClosedPublicActions