Page MenuHomeFreeBSD
Differential D32719

udp_input: remove a BSD stack relict
ClosedPublic
Actions

Authored by glebius on Oct 28 2021, 10:39 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 21, 9:24 AM
Unknown Object (File)
Sun, Apr 20, 9:39 AM
Unknown Object (File)
Sat, Apr 19, 3:18 AM
Unknown Object (File)
Fri, Apr 18, 5:03 AM
Unknown Object (File)
Mar 20 2025, 12:47 AM
Unknown Object (File)
Mar 11 2025, 6:34 PM
Unknown Object (File)
Mar 2 2025, 8:29 AM
Unknown Object (File)
Feb 23 2025, 10:06 PM
View All 89 Files
Subscribers
ae
imp
melifaro
zlei

Details

Reviewers
ae
Group Reviewers
transport
network
Commits
rG3358df297325: udp_input: remove a BSD stack relict
Summary

I should had removed it 9 years ago in 8ad458a471ca. That commit
left save_ip as a write-only variable.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 42528
Build 39416: arc lint + arc unit

Event Timeline

glebius created this revision.Oct 28 2021, 10:39 PM
Herald added a reviewer: transport. · View Herald TranscriptOct 28 2021, 10:39 PM
Herald added subscribers: melifaro, imp. · View Herald Transcript
glebius requested review of this revision.Oct 28 2021, 10:39 PM
Harbormaster completed remote builds in B42425: Diff 97638.Oct 28 2021, 10:39 PM
glebius added a reviewer: network. glebius removed 1 blocking reviewer(s): transport.Oct 28 2021, 10:40 PM
glebius added a child revision: D32718: blackhole(4): disable for locally originated TCP/UDP packets.
ae added a subscriber: ae.Oct 29 2021, 8:25 PM

It isn't write only variable. At line 501 original IP header can be changed, this variable keeps its copy.

glebius updated this revision to Diff 97878.Nov 2 2021, 6:38 PM

Thanks Andrew for noticing that checksum calculation actually
alters IP header, despite the char b[9] saver.

Harbormaster completed remote builds in B42528: Diff 97878.Nov 2 2021, 6:38 PM
ae accepted this revision as: ae.Nov 2 2021, 7:17 PM
ae added inline comments.
sys/netinet/udp_usrreq.c
492

What you think, if do it like this:

char b[offsetof(struct ipovly, ih_src)];
struct ipovly *p = (stuct ipovly *)ip;

bcopy(p, b, sizeof(b));
bzero(p, sizeof(p->ih_x1));
p->ih_len = ...
...
bcopy(b, p, sizeof(b));
This revision is now accepted and ready to land.Nov 2 2021, 7:17 PM
glebius added a comment.Nov 2 2021, 7:38 PM
In D32719#738820, @ae wrote:

It isn't write only variable. At line 501 original IP header can be changed, this variable keeps its copy.

There is another saver there - the char b[9]. It saves everything and restores back. The only value thrashed

sys/netinet/udp_usrreq.c
492

Great idea, thanks!

glebius updated this revision to Diff 97885.Nov 2 2021, 7:52 PM

Implement as Andrey suggests.

This revision now requires review to proceed.Nov 2 2021, 7:52 PM
Harbormaster completed remote builds in B42530: Diff 97885.Nov 2 2021, 7:52 PM
glebius marked an inline comment as done.Nov 2 2021, 7:55 PM
This revision was not accepted when it landed; it landed in state Needs Review.Nov 3 2021, 5:45 PM
Closed by commit rG3358df297325: udp_input: remove a BSD stack relict (authored by glebius). · Explain Why
This revision was automatically updated to reflect the committed changes.
glebius added a commit: rG3358df297325: udp_input: remove a BSD stack relict.
zlei added a subscriber: zlei.Oct 30 2024, 8:37 AM
zlei added inline comments.
sys/netinet/udp_usrreq.c
492

offsetof(struct ipovly, ih_src) is actually 12, not the same with the original hardcode 9. Is this intentional ?

Revision Contents
Changeset List

PathSize
sys/
netinet/
17 lines

Diff 97878

View Options

sys/netinet/udp_usrreq.c

Loading...