riscv: Implement pmap_mapdev_attr
ClosedPublic
Actions

Authored by jrtc27 on Oct 10 2021, 7:08 PM.

Details

Reviewers

markj
mhorne

Commits

rGaf818612a5d3: riscv: Implement pmap_mapdev_attr
rG682c00a6ce2f: riscv: Implement pmap_mapdev_attr

Summary

This is needed for LinuxKPI's _ioremap_attr. This reuses the generic
implementation introduced for aarch64, and itself requires implementing
pmap_kenter, which is trivial to do given riscv currently treats all
mapping attributes the same due to the Svpbmt extension not yet being
ratified and in hardware.

MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jrtc27 created this revision.Oct 10 2021, 7:08 PM

Herald added a subscriber: imp. · View Herald TranscriptOct 10 2021, 7:08 PM

jrtc27 requested review of this revision.Oct 10 2021, 7:08 PM

Harbormaster completed remote builds in B42056: Diff 96636.Oct 10 2021, 7:08 PM

jrtc27 added a child revision: D32446: LinuxKPI: Implement _ioremap_attr for riscv.Oct 10 2021, 7:10 PM

jrtc27 edited the summary of this revision. (Show Details)Oct 10 2021, 7:21 PM

markj accepted this revision.Oct 11 2021, 5:24 PM

markj added inline comments.

sys/riscv/riscv/pmap.c
919

This revision is now accepted and ready to land.Oct 11 2021, 5:24 PM

mhorne accepted this revision.Oct 12 2021, 1:48 PM

mhorne added inline comments.

sys/riscv/include/pmap.h
148	It would be nice to eventually land on a common interface for `pmap_kenter()` across various architectures, but matching arm64 here is sensible and required.

jrtc27 added inline comments.Oct 15 2021, 6:30 PM

sys/riscv/include/pmap.h
148	Yeah, though most other architectures assume size is PAGE_SIZE so would require a bit more work than just adding arguments to their implementations
sys/riscv/riscv/pmap.c
919	Good point, will do on commit