Differential D32107

cryptodev: Permit explicit IV/nonce and MAC/tag lengths.
ClosedPublic
Actions

Authored by jhb on Sep 24 2021, 6:04 PM.

Tags

None

Referenced Files

	F174710673: D32107.id95641.diff
	Mon, Oct 5, 9:45 AM

	F174706289: D32107.id.diff
	Mon, Oct 5, 9:02 AM

	F174694210: D32107.id96376.diff
	Mon, Oct 5, 6:37 AM

	Unknown Object (File)
	Sun, Oct 4, 3:57 PM

	Unknown Object (File)
	Fri, Oct 2, 9:23 PM

	Unknown Object (File)
	Fri, Oct 2, 5:14 PM

	Unknown Object (File)
	Wed, Sep 30, 6:53 PM

	Unknown Object (File)
	Sun, Sep 20, 5:33 AM

Subscribers

Details

Reviewers

Group Reviewers

Commits

rG38b8a2be5c48: cryptodev: Permit explicit IV/nonce and MAC/tag lengths.
rG16676123fc85: cryptodev: Permit explicit IV/nonce and MAC/tag lengths.

Summary

Add 'ivlen' and 'maclen' fields to the structure used for CIOGSESSION2
to specify the explicit IV/nonce and MAC/tag lengths for crypto
sessions. If these fields are zero, the default lengths are used.

This permits selecting an alternate nonce length for AEAD ciphers such
as AES-CCM which support multiple nonce leengths. It also supports
truncated MACs as input to AEAD or ETA requests.

Sponsored by: The FreeBSD Foundation

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 41905
Build 38793: arc lint + arc unit

Event Timeline

jhb created this revision.Sep 24 2021, 6:04 PM

Herald added a reviewer: manpages. · View Herald TranscriptSep 24 2021, 6:04 PM

Herald added subscribers: jmg, imp. · View Herald Transcript

jhb requested review of this revision.Sep 24 2021, 6:04 PM

jhb added a parent revision: D32106: cryptosoft, ccr: Use crp_iv directly for AES-CCM and AES-GCM..

jhb added a child revision: D32108: cryptodev: Permit CIOCCRYPT for AEAD ciphers..

Harbormaster completed remote builds in B41708: Diff 95641.Sep 24 2021, 6:05 PM

jhb added a reviewer: markj.Sep 27 2021, 9:33 PM

markj added inline comments.Sep 28 2021, 4:03 PM

sys/opencrypto/cryptodev.c
598	Why is this assignment needed? It is done again below.

jhb marked an inline comment as done.Oct 1 2021, 8:59 PM

jhb added inline comments.

sys/opencrypto/cryptodev.c
598	Oops, an earlier leftover from my first cut at doing this.

Drop an unnecessary line.

Harbormaster completed remote builds in B41905: Diff 96110.Oct 1 2021, 9:00 PM

markj accepted this revision.Oct 1 2021, 9:42 PM

This revision is now accepted and ready to land.Oct 1 2021, 9:42 PM

Closed by commit rG16676123fc85: cryptodev: Permit explicit IV/nonce and MAC/tag lengths. (authored by jhb). · Explain WhyOct 6 2021, 9:11 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG16676123fc85: cryptodev: Permit explicit IV/nonce and MAC/tag lengths..

jhb added a commit: rG38b8a2be5c48: cryptodev: Permit explicit IV/nonce and MAC/tag lengths..Oct 21 2021, 10:04 PM

Revision Contents
Changeset List

Path

Size

share/

man/

man4/

22 lines

sys/

opencrypto/

9 lines

29 lines

Diff 96110

share/man/man4/crypto.4

Loading...

sys/opencrypto/cryptodev.h

Loading...

sys/opencrypto/cryptodev.c

Loading...