Paths

Table of Contentst

Differential D32113

aesni: Handle requests with an empty payload.
ClosedPublic
Actions

Authored by jhb on Sep 24 2021, 6:05 PM.

Tags

None

Referenced Files

	F170793896: D32113.id.diff
	Sun, Sep 6, 4:14 PM

	F170725357: D32113.id96382.diff
	Sun, Sep 6, 5:56 AM

	Unknown Object (File)
	Sat, Sep 5, 11:09 PM

	Unknown Object (File)
	Sat, Sep 5, 5:20 AM

	Unknown Object (File)
	Fri, Sep 4, 10:01 AM

	Unknown Object (File)
	Thu, Sep 3, 5:52 PM

	Unknown Object (File)
	Thu, Sep 3, 2:40 AM

	Unknown Object (File)
	Thu, Sep 3, 1:06 AM

Subscribers

Details

Reviewers: None
Commits: rGa5d3890803e6: aesni: Handle requests with an empty payload.
rGd718c2d3c805: aesni: Handle requests with an empty payload.

Summary

Sponsored by: The FreeBSD Foundation

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Sep 24 2021, 6:05 PM

Herald added subscribers: jmg, imp. · View Herald TranscriptSep 24 2021, 6:05 PM

jhb requested review of this revision.Sep 24 2021, 6:05 PM

jhb added a parent revision: D32112: aesni: Support multiple nonce lengths for AES-CCM..

jhb added a child revision: D32114: aesni: Permit AES-CCM requests with neither payload nor AAD..

Harbormaster completed remote builds in B41714: Diff 95647.Sep 24 2021, 6:05 PM

This was triggered by the AES-CCM KAT vectors some of which use an empty payload.

emaste added a subscriber: markj.Sep 24 2021, 6:24 PM

emaste added inline comments.

sys/crypto/aesni/aesni.c
718–722	this seems like it could be a reasonable place to apply `{}` on all branches if at least some have them

jhb marked an inline comment as done.Oct 1 2021, 9:33 PM

More braces.

Harbormaster completed remote builds in B41930: Diff 96156.Oct 2 2021, 2:16 PM

This revision was not accepted when it landed; it landed in state Needs Review.Oct 6 2021, 9:11 PM

Closed by commit rGd718c2d3c805: aesni: Handle requests with an empty payload. (authored by jhb). · Explain Why

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rGd718c2d3c805: aesni: Handle requests with an empty payload..

jhb added a commit: rGa5d3890803e6: aesni: Handle requests with an empty payload..Oct 21 2021, 10:05 PM

Revision Contents
Changeset List

Path

Size

sys/

crypto/

aesni/

28 lines

Diff 96382

sys/crypto/aesni/aesni.c

Loading...