crypto: Permit variable-sized IVs for ciphers with a reinit hook.
ClosedPublic
Actions

Authored by jhb on Sep 24 2021, 6:04 PM.

Details

Reviewers

Commits

rGde705beeef63: crypto: Permit variable-sized IVs for ciphers with a reinit hook.
rG1833d6042c9a: crypto: Permit variable-sized IVs for ciphers with a reinit hook.

Summary

Add a 'len' argument to the reinit hook in 'struct enc_xform' to
permit support for AEAD ciphers such as AES-CCM and Chacha20-Poly1305
which support different nonce lengths.

Sponsored by: Chelsio Communications, The FreeBSD Foundation

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 41904
Build 38792: arc lint + arc unit

Event Timeline

jhb created this revision.Sep 24 2021, 6:04 PM

Herald added subscribers: ae, jmg, imp. · View Herald TranscriptSep 24 2021, 6:04 PM

jhb requested review of this revision.Sep 24 2021, 6:04 PM

jhb added a parent revision: D32104: ccp, ccr: Simplify drivers to assume an AES-GCM IV length of 12..

jhb added a child revision: D32106: cryptosoft, ccr: Use crp_iv directly for AES-CCM and AES-GCM..

Harbormaster completed remote builds in B41706: Diff 95639.Sep 24 2021, 6:05 PM

jhb added a reviewer: markj.Sep 27 2021, 9:31 PM

markj added inline comments.Sep 28 2021, 3:36 PM

sys/opencrypto/xform_aes_icm.c
117	I think it'd be a bit nicer to call it `ivlen` here and below.
sys/opencrypto/xform_aes_xts.c
93	Perhaps assert that AES_XTS_IVSIZE == len? Here and elsewhere where we don't actually handle a variable length IV. (I know that CCM gets updated in a follow-up commit.)