Paths

Table of Contentst

Differential D32245

nvme_ctrlr_enable: Small style nits
ClosedPublic
Actions

Authored by imp on Oct 1 2021, 3:21 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Sep 8, 7:38 AM

	Unknown Object (File)
	Sun, Sep 6, 9:14 PM

	Unknown Object (File)
	Sun, Sep 6, 2:13 AM

	Unknown Object (File)
	Sat, Sep 5, 11:39 AM

	Unknown Object (File)
	Sat, Sep 5, 11:36 AM

	Unknown Object (File)
	Sat, Sep 5, 8:13 AM

	Unknown Object (File)
	Sat, Sep 5, 5:25 AM

	Unknown Object (File)
	Sat, Sep 5, 4:53 AM

Subscribers

Details

Reviewers

mav
cperciva
chuck

Commits

rG02325a44b520: nvme_ctrlr_enable: Small style nits
rGa245627a4e95: nvme_ctrlr_enable: Small style nits

Summary

Rewrite the nested if's using the preferred FreeBSD style for branches
of ifs that return. NFC.

Sponsored by: Netflix

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

imp created this revision.Oct 1 2021, 3:21 AM

Herald added a subscriber: dab. · View Herald TranscriptOct 1 2021, 3:21 AM

imp requested review of this revision.Oct 1 2021, 3:21 AM

Harbormaster completed remote builds in B41875: Diff 96041.Oct 1 2021, 3:21 AM

imp added reviewers: mav, cperciva, chuck.Oct 1 2021, 3:32 AM

mav added inline comments.Oct 1 2021, 3:46 AM

sys/dev/nvme/nvme_ctrlr.c
318	I have no objections, but if you flip this (en == 1) condition, you could use the same formatting as in next chunk,

Start with en == 0, per mav, to make this less indented too.

Harbormaster completed remote builds in B41880: Diff 96046.Oct 1 2021, 4:39 AM

mav accepted this revision.Oct 1 2021, 2:25 PM

This revision is now accepted and ready to land.Oct 1 2021, 2:25 PM

chuck accepted this revision.Oct 1 2021, 2:29 PM

chuck added inline comments.

sys/dev/nvme/nvme_ctrlr.c
306–307	With the restructuring, I'm mixed on whether this comment needs to exist. It was helpful in the else clause to remind the reader of the state. But with the `en == 0` immediately above, maybe the comment isn't as useful. I'm good either keeping it or ditching it.

Minor tweak in comment (mostly FYI)

This revision now requires review to proceed.Oct 1 2021, 3:42 PM

Harbormaster completed remote builds in B41885: Diff 96074.Oct 1 2021, 3:42 PM

fold in chuck's comments and go a step further

Harbormaster completed remote builds in B41889: Diff 96079.Oct 1 2021, 4:44 PM

This revision was not accepted when it landed; it landed in state Needs Review.Oct 1 2021, 4:57 PM

Closed by commit rGa245627a4e95: nvme_ctrlr_enable: Small style nits (authored by imp). · Explain Why

This revision was automatically updated to reflect the committed changes.

imp added a commit: rGa245627a4e95: nvme_ctrlr_enable: Small style nits.

mav added a commit: rG02325a44b520: nvme_ctrlr_enable: Small style nits.Jan 21 2022, 2:28 AM

Revision Contents
Changeset List

Path

Size

sys/

dev/

nvme/

33 lines

Diff 96082

sys/dev/nvme/nvme_ctrlr.c

Loading...