Page MenuHomeFreeBSD
Differential D31770

ipsec: If no PMTU in hostcache assume it's equal to link's MTU
ClosedPublic
Actions

Authored by bag_semihalf.com on Sep 1 2021, 11:43 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 7, 4:48 PM
Unknown Object (File)
Thu, Mar 28, 4:24 PM
Unknown Object (File)
Mar 7 2024, 6:22 PM
Unknown Object (File)
Feb 15 2024, 2:37 AM
Unknown Object (File)
Feb 15 2024, 2:37 AM
Unknown Object (File)
Feb 15 2024, 2:37 AM
Unknown Object (File)
Feb 15 2024, 2:25 AM
Unknown Object (File)
Feb 11 2024, 8:46 PM
View All 37 Files
Subscribers
dgr_semihalf.com
kd
melifaro

Details

Reviewers
mw
wma
tuexen
ae
Group Reviewers
transport
Commits
rGb4220bf387e6: ipsec: If no PMTU in hostcache assume it's equal to link's MTU
Summary

If we fail to find to PMTU in hostcache, we assume it's equal
to link's MTU.

This patch prevents packets larger then link's MTU to be dropped
silently if there is no PMTU in hostcache.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bag_semihalf.com created this revision.Sep 1 2021, 11:43 AM
Herald added a subscriber: melifaro. · View Herald TranscriptSep 1 2021, 11:43 AM
bag_semihalf.com requested review of this revision.Sep 1 2021, 11:43 AM
bag_semihalf.com added a parent revision: D31769: ipsec: Add PMTUD support for IPsec IPv4 over IPv6 tunnel.Sep 1 2021, 11:45 AM
bag_semihalf.com added a child revision: D31771: ipsec: Add support for PMTUD for IPv6 tunnels.
melifaro added inline comments.Sep 1 2021, 10:39 PM
sys/netipsec/ipsec_output.c
357

Why can't we reuse the previous case?

bag_semihalf.com added inline comments.Sep 2 2021, 1:21 PM
sys/netipsec/ipsec_output.c
357

In my option this way is clearer what the code does. And I don’t think we should call tcp_maxmtu when we don’t need it, because it searches through the routing table.

This revision was not accepted when it landed; it landed in state Needs Review.Sep 24 2021, 8:30 AM
Closed by commit rGb4220bf387e6: ipsec: If no PMTU in hostcache assume it's equal to link's MTU (authored by bag_semihalf.com, committed by wma). · Explain Why
This revision was automatically updated to reflect the committed changes.
wma added a commit: rGb4220bf387e6: ipsec: If no PMTU in hostcache assume it's equal to link's MTU.

Revision Contents
Changeset List

PathSize
sys/
netipsec/
22 lines

Diff 95612

View Options

sys/netipsec/ipsec_output.c

Loading...