Page MenuHomeFreeBSD

boottrace: annotate init and shutdown utilities
ClosedPublic

Authored by mhorne on Sep 13 2021, 3:16 PM.
Tags
None
Referenced Files
F154961221: D31928.id95043.diff
Thu, Apr 30, 8:20 AM
Unknown Object (File)
Mon, Apr 27, 11:39 PM
Unknown Object (File)
Tue, Apr 21, 11:49 AM
Unknown Object (File)
Tue, Apr 21, 9:26 AM
Unknown Object (File)
Thu, Apr 16, 9:55 PM
Unknown Object (File)
Thu, Apr 16, 10:00 AM
Unknown Object (File)
Thu, Apr 16, 1:33 AM
Unknown Object (File)
Tue, Apr 14, 12:14 AM

Details

Summary

Add boottrace annotations to record events in init(8), shutdown(8), and
reboot(8). This is the first piece of the boottrace userland support.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 41479
Build 38368: arc lint + arc unit

Event Timeline

sbin/init/init.c
1741

Declarations appearing mid-block are generally discouraged

sbin/init/init.c
1741

Yeah. I think I kept this one here because it would be easier to overlook the static qualifier if it was declared at the start of the function. I wouldn't oppose increasing the scope and moving it to the top of the file.

This revision was not accepted when it landed; it landed in state Needs Review.Feb 22 2022, 12:18 AM
This revision was automatically updated to reflect the committed changes.