Page MenuHomeFreeBSD

pf: qid and pqid can be uint16_t
ClosedPublic

Authored by kp on Sep 7 2021, 2:37 PM.
Tags
None
Referenced Files
F83320603: D31873.diff
Wed, May 8, 8:44 PM
Unknown Object (File)
Sat, Apr 20, 5:08 PM
Unknown Object (File)
Feb 7 2024, 1:41 AM
Unknown Object (File)
Dec 20 2023, 4:03 AM
Unknown Object (File)
Dec 14 2023, 9:43 PM
Unknown Object (File)
Dec 10 2023, 11:13 AM
Unknown Object (File)
Dec 6 2023, 1:56 PM
Unknown Object (File)
Nov 28 2023, 4:20 PM

Details

Summary

tag2name() returns a uint16_t, so we don't need to use uint32_t for the
qid (or pqid). This reduces the size of struct pf_kstate slightly. That
in turn buys us space to add extra fields for dummynet later.

Happily these fields are not exposed to user space (there are user space
versions of them, but they can just stay uint32_t), so there's no ABI
breakage in modifying this.

MFC after: 1 week
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 41418
Build 38307: arc lint + arc unit