Page MenuHomeFreeBSD

pf: qid and pqid can be uint16_t
ClosedPublic

Authored by kp on Sep 7 2021, 2:37 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 7 2024, 1:41 AM
Unknown Object (File)
Dec 20 2023, 4:03 AM
Unknown Object (File)
Dec 14 2023, 9:43 PM
Unknown Object (File)
Dec 10 2023, 11:13 AM
Unknown Object (File)
Dec 6 2023, 1:56 PM
Unknown Object (File)
Nov 28 2023, 4:20 PM
Unknown Object (File)
Nov 23 2023, 10:29 PM
Unknown Object (File)
Nov 23 2023, 4:44 PM

Details

Summary

tag2name() returns a uint16_t, so we don't need to use uint32_t for the
qid (or pqid). This reduces the size of struct pf_kstate slightly. That
in turn buys us space to add extra fields for dummynet later.

Happily these fields are not exposed to user space (there are user space
versions of them, but they can just stay uint32_t), so there's no ABI
breakage in modifying this.

MFC after: 1 week
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable