Page MenuHomeFreeBSD
Differential D31764

tcp: document TCP Fast Open (RFC 7413) in tcp(4)
ClosedPublic
Actions

Authored by philip on Sep 1 2021, 8:31 AM.
Tags
None
Referenced Files
F157180846: D31764.id94523.diff
Tue, May 19, 2:10 AM
Unknown Object (File)
Sun, May 17, 7:40 PM
Unknown Object (File)
Tue, May 12, 2:25 PM
Unknown Object (File)
Mon, May 11, 9:51 PM
Unknown Object (File)
Thu, Apr 30, 12:25 PM
Unknown Object (File)
Wed, Apr 29, 8:17 AM
Unknown Object (File)
Wed, Apr 29, 8:17 AM
Unknown Object (File)
Tue, Apr 28, 9:02 AM
View All Files
Subscribers
gbe
imp

Details

Reviewers
pkelsey
Group Reviewers
manpages
Commits
rG7aa030f7ccf4: tcp: document TCP Fast Open (RFC 7413) in tcp(4)
rG783ace226489: tcp: document TCP Fast Open (RFC 7413) in tcp(4)
rG71611b0c6885: tcp: document TCP Fast Open (RFC 7413) in tcp(4)
Summary

Adds documentation for the TCP_FASTOPEN socket option
and related MIB variables to the tcp(4) manual page.

PR: 257907
MFC after: 3 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

philip created this revision.Sep 1 2021, 8:31 AM
Herald added a reviewer: manpages. · View Herald TranscriptSep 1 2021, 8:31 AM
Herald added a subscriber: imp. · View Herald Transcript
philip requested review of this revision.Sep 1 2021, 8:31 AM
Harbormaster completed remote builds in B41305: Diff 94466.Sep 1 2021, 8:31 AM
philip added a reviewer: pkelsey.Sep 1 2021, 8:34 AM
gbe added a subscriber: gbe.Sep 1 2021, 4:49 PM

Two small suggestions, otherwise LGTM, and thanks for working on this PR.

share/man/man4/tcp.4
746

Suggestion, 'after this specified seconds'.

815

Suggestion, "from being established.".

philip updated this revision to Diff 94523.Sep 2 2021, 2:09 AM

Addressed suggestions from gbe.

Harbormaster completed remote builds in B41322: Diff 94523.Sep 2 2021, 2:09 AM
philip marked 2 inline comments as done.Sep 2 2021, 2:10 AM
philip updated this revision to Diff 94524.Sep 2 2021, 2:14 AM

Replace a couple more "being made" with "being established".

Suggested by: gbe

Harbormaster completed remote builds in B41323: Diff 94524.Sep 2 2021, 2:14 AM
gbe accepted this revision as: manpages.Sep 2 2021, 8:55 AM

LGTM!

This revision was not accepted when it landed; it landed in state Needs Review.Sep 3 2021, 2:35 AM
Closed by commit rG71611b0c6885: tcp: document TCP Fast Open (RFC 7413) in tcp(4) (authored by philip). · Explain Why
This revision was automatically updated to reflect the committed changes.
philip added a commit: rG71611b0c6885: tcp: document TCP Fast Open (RFC 7413) in tcp(4).
philip added a commit: rG783ace226489: tcp: document TCP Fast Open (RFC 7413) in tcp(4).Sep 6 2021, 1:16 AM
philip added a commit: rG7aa030f7ccf4: tcp: document TCP Fast Open (RFC 7413) in tcp(4).

Revision Contents
Changeset List

PathSize
share/
man/
man4/
134 lines

Diff 94600

View Options

share/man/man4/tcp.4

Loading...