pf: Only hook the Ethernet pfil hook when we have rules
ClosedPublic
Actions

Authored by kp on Aug 31 2021, 8:25 AM.

Details

Reviewers

None

Group Reviewers

network
pfsense

Commits

rG6b7c2680039b: pf: Only hook the Ethernet pfil hook when we have rules

Summary

Avoid the overhead of the Ethernet pfil hooks if we don't have any
Ethernet rules.

Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 41281
Build 38170: arc lint + arc unit

Event Timeline

kp created this revision.Aug 31 2021, 8:25 AM

Herald added subscribers: melifaro, farrokhi, imp. · View Herald TranscriptAug 31 2021, 8:25 AM

kp requested review of this revision.Aug 31 2021, 8:25 AM

kp added a parent revision: D31741: pf: SDTs for ether rule matching.

Harbormaster completed remote builds in B41281: Diff 94418.Aug 31 2021, 8:25 AM

kp added a child revision: D31743: pf tests: MAC address filtering test.Aug 31 2021, 8:25 AM

Rebase

Harbormaster completed remote builds in B41836: Diff 95943.Sep 29 2021, 3:02 PM

Rebase & cleanup

Harbormaster completed remote builds in B42109: Diff 96816.Oct 13 2021, 3:32 PM

kp mentioned this in D31737: pf: Initial Ethernet level filtering code.Dec 23 2021, 11:02 AM

This revision was not accepted when it landed; it landed in state Needs Review.Mar 2 2022, 4:01 PM

Closed by commit rG6b7c2680039b: pf: Only hook the Ethernet pfil hook when we have rules (authored by kp). · Explain Why

This revision was automatically updated to reflect the committed changes.

kp added a commit: rG6b7c2680039b: pf: Only hook the Ethernet pfil hook when we have rules.

Herald added a subscriber: glebius. · View Herald TranscriptMar 2 2022, 4:01 PM

Revision Contents
Changeset List

Path

Size

sys/

netpfil/

pf/

pf_ioctl.c

59 lines

Diff 94418

View Options

pf: Only hook the Ethernet pfil hook when we have rulesClosedPublicActions