Tags

None

Referenced Files

	F144408329: D31749.id94425.diff
	Sun, Feb 8, 7:11 AM

	F144338695: D31749.id95555.diff
	Sat, Feb 7, 10:29 PM

	F144330903: D31749.id103391.diff
	Sat, Feb 7, 9:31 PM

	F144293655: D31749.id96823.diff
	Sat, Feb 7, 4:46 PM

	Unknown Object (File)
	Sat, Jan 31, 12:24 PM

	Unknown Object (File)
	Wed, Jan 28, 6:43 AM

	Unknown Object (File)
	Mon, Jan 26, 9:05 PM

	Unknown Object (File)
	Sun, Jan 25, 10:31 PM

View All Files

Subscribers

imp

Details

Reviewers

None

Group Reviewers

network
pfsense

Commits

rGc696d5c72fe1: pfctl: Don't print (ether) to / from if they're not set

Summary

If we're not filtering on a specific MAC address don't print it at all,
rather than showing an all-zero address.

Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kp created this revision.Aug 31 2021, 8:28 AM

Herald added a subscriber: imp. · View Herald TranscriptAug 31 2021, 8:28 AM

kp requested review of this revision.Aug 31 2021, 8:28 AM

kp added a parent revision: D31748: pf: Support clearing ether counters.

kp added a child revision: D31750: pfctl: Document displaying Ethernet rules.

Harbormaster completed remote builds in B41288: Diff 94425.Aug 31 2021, 8:29 AM

Don't print from/to when not set.

Harbormaster completed remote builds in B41663: Diff 95555.Sep 23 2021, 10:08 AM

Rebase

Harbormaster completed remote builds in B41839: Diff 95946.Sep 29 2021, 3:03 PM

Rebase

Harbormaster completed remote builds in B42116: Diff 96823.Oct 13 2021, 3:34 PM

This revision was not accepted when it landed; it landed in state Needs Review.Mar 2 2022, 4:02 PM

Closed by commit rGc696d5c72fe1: pfctl: Don't print (ether) to / from if they're not set (authored by kp). · Explain Why

This revision was automatically updated to reflect the committed changes.

kp added a commit: rGc696d5c72fe1: pfctl: Don't print (ether) to / from if they're not set.

pfctl: Don't print (ether) to / from if they're not set
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 103391

lib/libpfctl/libpfctl.h

lib/libpfctl/libpfctl.c

sbin/pfctl/pfctl_parser.c

pfctl: Don't print (ether) to / from if they're not setClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 103391

lib/libpfctl/libpfctl.h

lib/libpfctl/libpfctl.c

sbin/pfctl/pfctl_parser.c

pfctl: Don't print (ether) to / from if they're not set
ClosedPublic
Actions

Revision Contents
Changeset List