Page MenuHomeFreeBSD
Differential D31749

pfctl: Don't print (ether) to / from if they're not set
ClosedPublic
Actions

Authored by kp on Aug 31 2021, 8:28 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Oct 15, 5:23 AM
Unknown Object (File)
Mon, Oct 13, 2:18 PM
Unknown Object (File)
Mon, Oct 13, 2:18 PM
Unknown Object (File)
Mon, Oct 13, 2:18 PM
Unknown Object (File)
Mon, Oct 13, 2:18 PM
Unknown Object (File)
Mon, Oct 13, 2:18 PM
Unknown Object (File)
Mon, Oct 13, 2:18 PM
Unknown Object (File)
Mon, Oct 13, 1:31 AM
View All Files
Subscribers
imp

Details

Reviewers
None
Group Reviewers
network
pfsense
Commits
rGc696d5c72fe1: pfctl: Don't print (ether) to / from if they're not set
Summary

If we're not filtering on a specific MAC address don't print it at all,
rather than showing an all-zero address.

Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kp created this revision.Aug 31 2021, 8:28 AM
Herald added a subscriber: imp. · View Herald TranscriptAug 31 2021, 8:28 AM
kp requested review of this revision.Aug 31 2021, 8:28 AM
kp added a parent revision: D31748: pf: Support clearing ether counters.
kp added a child revision: D31750: pfctl: Document displaying Ethernet rules.
Harbormaster completed remote builds in B41288: Diff 94425.Aug 31 2021, 8:29 AM
kp updated this revision to Diff 95555.Sep 23 2021, 10:08 AM

Don't print from/to when not set.

Harbormaster completed remote builds in B41663: Diff 95555.Sep 23 2021, 10:08 AM
kp updated this revision to Diff 95946.Sep 29 2021, 3:03 PM

Rebase

Harbormaster completed remote builds in B41839: Diff 95946.Sep 29 2021, 3:03 PM
kp updated this revision to Diff 96823.Oct 13 2021, 3:34 PM

Rebase

Harbormaster completed remote builds in B42116: Diff 96823.Oct 13 2021, 3:34 PM
This revision was not accepted when it landed; it landed in state Needs Review.Mar 2 2022, 4:02 PM
Closed by commit rGc696d5c72fe1: pfctl: Don't print (ether) to / from if they're not set (authored by kp). · Explain Why
This revision was automatically updated to reflect the committed changes.
kp added a commit: rGc696d5c72fe1: pfctl: Don't print (ether) to / from if they're not set.

Revision Contents
Changeset List

PathSize
lib/
libpfctl/
1 line
4 lines
sbin/
pfctl/
22 lines

Diff 103391

View Options

lib/libpfctl/libpfctl.h

Loading...
View Options

lib/libpfctl/libpfctl.c

Loading...
View Options

sbin/pfctl/pfctl_parser.c

Loading...