fsetown: Avoid gotos for error handling
ClosedPublic
Actions

Authored by markj on Aug 24 2021, 9:08 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Apr 20, 4:33 AM

	Unknown Object (File)
	Mon, Apr 20, 4:33 AM

	Unknown Object (File)
	Sat, Apr 18, 12:20 AM

	Unknown Object (File)
	Mar 18 2026, 4:07 AM

	Unknown Object (File)
	Mar 15 2026, 6:21 AM

	Unknown Object (File)
	Mar 15 2026, 2:16 AM

	Unknown Object (File)
	Mar 9 2026, 7:36 PM

	Unknown Object (File)
	Mar 8 2026, 9:45 PM

View All Files

Subscribers

imp

Details

Reviewers

kib

Commits

rGa507a40f3b58: fsetown: Simplify error handling

Summary

This simplifies control flow somewhat at the expense of extra nesting.

Suggested by: kib

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Aug 24 2021, 9:08 PM

Herald added a subscriber: imp. · View Herald TranscriptAug 24 2021, 9:08 PM

markj requested review of this revision.Aug 24 2021, 9:08 PM

Harbormaster completed remote builds in B41190: Diff 94143.Aug 24 2021, 9:08 PM

markj mentioned this in D31661: Fix a pair of bugs in fsetown().Aug 24 2021, 9:10 PM

kib accepted this revision.Aug 24 2021, 10:28 PM

This revision is now accepted and ready to land.Aug 24 2021, 10:28 PM

Closed by commit rGa507a40f3b58: fsetown: Simplify error handling (authored by markj). · Explain WhyAug 25 2021, 8:31 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rGa507a40f3b58: fsetown: Simplify error handling.

Revision Contents
Changeset List

Path

Size

sys/

kern/

kern_descrip.c

106 lines

Diff 94191

View Options

fsetown: Avoid gotos for error handlingClosedPublicActions