Page MenuHomeFreeBSD
Differential D31505

vfs: Rename ioflg to ioflag in vn_deallocate
ClosedPublic
Actions

Authored by khng on Aug 11 2021, 8:27 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 29, 2:25 AM
Unknown Object (File)
Fri, Apr 26, 11:43 PM
Unknown Object (File)
Wed, Apr 24, 2:25 PM
Unknown Object (File)
Tue, Apr 23, 4:45 PM
Unknown Object (File)
Sun, Apr 21, 3:09 AM
Unknown Object (File)
Sun, Apr 21, 3:09 AM
Unknown Object (File)
Sun, Apr 21, 2:55 AM
Unknown Object (File)
Mar 28 2024, 1:23 PM
View All 33 Files
Subscribers
bcr
imp

Details

Reviewers
kib
Group Reviewers
manpages
Commits
rG4a9b832a2ad7: vfs: Rename ioflg to ioflag in vn_deallocate
Summary

Sponsored by: The FreeBSD Foundation

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

khng created this revision.Aug 11 2021, 8:27 AM
Herald added a reviewer: manpages. · View Herald TranscriptAug 11 2021, 8:27 AM
Herald added a subscriber: imp. · View Herald Transcript
khng requested review of this revision.Aug 11 2021, 8:27 AM
Harbormaster completed remote builds in B40986: Diff 93531.Aug 11 2021, 8:27 AM
khng added a parent revision: D31500: vfs: Add ioflag to VOP_DEALLOCATE(9).Aug 11 2021, 8:28 AM
khng removed a parent revision: D31500: vfs: Add ioflag to VOP_DEALLOCATE(9).
khng added a child revision: D31500: vfs: Add ioflag to VOP_DEALLOCATE(9).
khng added a reviewer: kib.
bcr accepted this revision as: manpages.Aug 11 2021, 8:52 AM
bcr added a subscriber: bcr.

OK for the manpage part of the change.

kib accepted this revision.Aug 11 2021, 9:02 AM

Such change does not need a review.

This revision is now accepted and ready to land.Aug 11 2021, 9:02 AM
kib added inline comments.Aug 11 2021, 9:03 AM
sys/kern/vfs_vnops.c
3466

And you left the style issue lingering.

khng added inline comments.Aug 11 2021, 9:06 AM
sys/kern/vfs_vnops.c
3466

This was fixed on D31500 instead.

kib added inline comments.Aug 11 2021, 9:26 AM
sys/kern/vfs_vnops.c
3466

This is purely a style change, while D31500 modifies the runtime behavior.

khng updated this revision to Diff 93535.Aug 11 2021, 9:43 AM
khng mentioned this in D31500: vfs: Add ioflag to VOP_DEALLOCATE(9).

ioflag checking style fix ends up here.

This revision now requires review to proceed.Aug 11 2021, 9:44 AM
Harbormaster completed remote builds in B40990: Diff 93535.Aug 11 2021, 9:44 AM
This revision was not accepted when it landed; it landed in state Needs Review.Aug 11 2021, 9:47 AM
Closed by commit rG4a9b832a2ad7: vfs: Rename ioflg to ioflag in vn_deallocate (authored by khng). · Explain Why
This revision was automatically updated to reflect the committed changes.
khng added a commit: rG4a9b832a2ad7: vfs: Rename ioflg to ioflag in vn_deallocate.

Revision Contents
Changeset List

PathSize
share/
man/
man9/
8 lines
sys/
kern/
14 lines

Diff 93536

View Options

share/man/man9/vn_deallocate.9

Loading...
View Options

sys/kern/vfs_vnops.c

Loading...