Page MenuHomeFreeBSD
Differential D31023

sifive_prci: Delay attachment until after clk_fixed
ClosedPublic
Actions

Authored by jrtc27 on Jul 5 2021, 12:02 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jul 14, 6:16 PM
Unknown Object (File)
Thu, Jul 9, 7:19 PM
Unknown Object (File)
Sun, Jul 5, 9:44 AM
Unknown Object (File)
Tue, Jun 30, 12:15 AM
Unknown Object (File)
Mon, Jun 29, 5:14 AM
Unknown Object (File)
Sun, Jun 28, 12:45 PM
Unknown Object (File)
Sat, Jun 27, 11:32 AM
Unknown Object (File)
Tue, Jun 23, 11:23 PM
View All Files
Subscribers
imp

Details

Reviewers
manu
kp
mhorne
Group Reviewers
riscv
Commits
rG276455b32167: sifive_prci: Delay attachment until after clk_fixed
rGdcbea9a2f465: sifive_prci: Delay attachment until after clk_fixed
Summary

This avoids noisy output from early attempts to attach before clk_fixed
has attached to the parent clocks.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 40838
Build 37727: arc lint + arc unit

Event Timeline

jrtc27 created this revision.Jul 5 2021, 12:02 AM
Herald added a subscriber: imp. · View Herald TranscriptJul 5 2021, 12:02 AM
jrtc27 requested review of this revision.Jul 5 2021, 12:02 AM
Harbormaster completed remote builds in B40270: Diff 91731.Jul 5 2021, 12:02 AM
jrtc27 added a parent revision: D31021: fu540_prci: Rename to sifive_prci and use ocd_data for FU540 specificity.Jul 5 2021, 12:23 AM
kp accepted this revision as: kp.Jul 5 2021, 9:21 AM
This revision is now accepted and ready to land.Jul 5 2021, 9:21 AM
manu added a comment.Jul 5 2021, 9:26 AM

Will that work with BUS_PASS_BUS + BUS_PASS_ORDER_LATE ?
That's usually what we do (i.e. not using direct numbers but only the defines).

jrtc27 added a comment.Jul 5 2021, 3:07 PM
In D31023#698207, @manu wrote:

Will that work with BUS_PASS_BUS + BUS_PASS_ORDER_LATE ?
That's usually what we do (i.e. not using direct numbers but only the defines).

Good question, I wrote this a few weeks ago and don't recall whether there was a reason why I didn't do that... I'll try it out and see if that breaks something in later passes.

jrtc27 updated this revision to Diff 93197.Aug 3 2021, 11:42 PM

BUS_PASS_ORDER_LATE works just fine instead of BUS_PASS_ORDER_MIDDLE + 1

This revision now requires review to proceed.Aug 3 2021, 11:42 PM
Harbormaster completed remote builds in B40838: Diff 93197.Aug 3 2021, 11:42 PM
mhorne accepted this revision.Aug 4 2021, 2:53 PM
This revision is now accepted and ready to land.Aug 4 2021, 2:53 PM
Closed by commit rGdcbea9a2f465: sifive_prci: Delay attachment until after clk_fixed (authored by jrtc27). · Explain WhyAug 7 2021, 6:28 PM
This revision was automatically updated to reflect the committed changes.
jrtc27 added a commit: rGdcbea9a2f465: sifive_prci: Delay attachment until after clk_fixed.
jrtc27 added a commit: rG276455b32167: sifive_prci: Delay attachment until after clk_fixed.Sep 7 2021, 12:11 PM

Revision Contents
Changeset List

PathSize
sys/
riscv/
sifive/
6 lines

Diff 93197

View Options

sys/riscv/sifive/sifive_prci.c

Loading...