rip: Add missing minimum length validation
ClosedPublic
Actions

Authored by markj on Jul 25 2021, 9:46 PM.

Tags

None

Referenced Files

	F174213225: D31302.diff
	Thu, Oct 1, 10:07 AM

	Unknown Object (File)
	Tue, Sep 29, 5:53 PM

	Unknown Object (File)
	Fri, Sep 25, 8:14 PM

	Unknown Object (File)
	Sun, Sep 20, 6:56 AM

	Unknown Object (File)
	Sun, Sep 20, 3:01 AM

	Unknown Object (File)
	Tue, Sep 8, 9:04 PM

	Unknown Object (File)
	Sat, Sep 5, 10:51 PM

	Unknown Object (File)
	Sat, Sep 5, 3:25 PM

Subscribers

Details

Reviewers

donner

Group Reviewers

network

Commits

rGba2182520273: rip: Add missing minimum length validation in rip_output()

Summary

If the socket is configured such that the sender is expected to supply
the IP header, then we need to verify that it actually did so.

Reported by: syzkaller+KMSAN
MFC after: 1 week

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 40669
Build 37558: arc lint + arc unit

Event Timeline

markj created this revision.Jul 25 2021, 9:46 PM

Herald added subscribers: melifaro, imp. · View Herald TranscriptJul 25 2021, 9:46 PM

markj requested review of this revision.Jul 25 2021, 9:46 PM

Harbormaster completed remote builds in B40669: Diff 92730.Jul 25 2021, 9:46 PM

markj added a reviewer: network.Jul 25 2021, 9:46 PM

Good catch.

This revision is now accepted and ready to land.Jul 25 2021, 10:29 PM

Closed by commit rGba2182520273: rip: Add missing minimum length validation in rip_output() (authored by markj). · Explain WhyJul 26 2021, 8:55 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rGba2182520273: rip: Add missing minimum length validation in rip_output().

Revision Contents
Changeset List

Path

Size

sys/

netinet/

raw_ip.c

9 lines

Diff 92730

View Options

rip: Add missing minimum length validationClosedPublicActions