Page MenuHomeFreeBSD
Differential D30702

pf: use M_WAITOK where possible
ClosedPublic
Actions

Authored by kp on Jun 9 2021, 5:00 PM.
Tags
None
Referenced Files
F105275188: D30702.diff
Sat, Dec 14, 8:50 AM
Unknown Object (File)
Thu, Dec 12, 9:34 AM
Unknown Object (File)
Wed, Dec 4, 1:00 PM
Unknown Object (File)
Tue, Nov 26, 9:15 AM
Unknown Object (File)
Tue, Nov 19, 5:07 PM
Unknown Object (File)
Nov 13 2024, 2:01 PM
Unknown Object (File)
Oct 31 2024, 5:28 PM
Unknown Object (File)
Oct 27 2024, 5:08 PM
View All 65 Files
Subscribers
bdrewery
donner
emaste
farrokhi
imp
melifaro

Details

Reviewers
donner
Group Reviewers
pfsense
network
Commits
rG3a57bb60f4ad: pf: use M_WAITOK where possible
rGea21980a3fac: pf: use M_WAITOK where possible
Summary

In the ioctl path use M_WAITOK allocations whereever possible. These are
less sensitive to memory pressure, and ioctl requests have no hard
deadlines.

MFC after: 1 week
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 39823
Build 36712: arc lint + arc unit

Event Timeline

kp created this revision.Jun 9 2021, 5:00 PM
Herald added subscribers: melifaro, farrokhi, emaste and 2 others. · View Herald TranscriptJun 9 2021, 5:00 PM
kp requested review of this revision.Jun 9 2021, 5:00 PM
Harbormaster completed remote builds in B39822: Diff 90642.Jun 9 2021, 5:00 PM
bdrewery added inline comments.Jun 9 2021, 5:06 PM
sys/netpfil/pf/pf_ioctl.c
3774–3775

These NULL checks are dead code now with M_WAITOK.

emaste added a comment.Jun 9 2021, 5:46 PM

Assume you meant to include only the sys/netpfil/pf/pf_ioctl.c changes?

kp added a comment.Jun 9 2021, 6:03 PM
In D30702#690012, @emaste wrote:

Assume you meant to include only the sys/netpfil/pf/pf_ioctl.c changes?

Gha, yes. I had a few local, uncommitted, changes, and apparently git-arc picked those up as well. And then helpfully removed them from my tree.

kp added a reviewer: network.Jun 9 2021, 6:03 PM
kp updated this revision to Diff 90654.Jun 9 2021, 6:37 PM
  • Remove unrelated changes
  • Don't check for NULL after M_WAITOK
Harbormaster completed remote builds in B39823: Diff 90654.Jun 9 2021, 6:37 PM
donner accepted this revision as: donner.Jun 9 2021, 7:21 PM
donner added a subscriber: donner.

As far as I can check, all those changes are outside of the hold lock, so this is fine.

This revision is now accepted and ready to land.Jun 9 2021, 7:21 PM
Closed by commit rGea21980a3fac: pf: use M_WAITOK where possible (authored by kp). · Explain WhyJun 10 2021, 12:21 PM
This revision was automatically updated to reflect the committed changes.
kp added a commit: rGea21980a3fac: pf: use M_WAITOK where possible.
kp added a commit: rG3a57bb60f4ad: pf: use M_WAITOK where possible.Jun 17 2021, 2:56 PM

Revision Contents
Changeset List

PathSize
sys/
netpfil/
pf/
78 lines

Diff 90654

View Options

sys/netpfil/pf/pf_ioctl.c

Loading...