pf: use M_WAITOK where possible
ClosedPublic
Actions

Authored by kp on Jun 9 2021, 5:00 PM.

Details

Reviewers

Group Reviewers

pfsense
network

Commits

rG3a57bb60f4ad: pf: use M_WAITOK where possible
rGea21980a3fac: pf: use M_WAITOK where possible

Summary

In the ioctl path use M_WAITOK allocations whereever possible. These are
less sensitive to memory pressure, and ioctl requests have no hard
deadlines.

MFC after: 1 week
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kp created this revision.Jun 9 2021, 5:00 PM

Herald added subscribers: melifaro, farrokhi, emaste and 2 others. · View Herald TranscriptJun 9 2021, 5:00 PM

kp requested review of this revision.Jun 9 2021, 5:00 PM

Harbormaster completed remote builds in B39822: Diff 90642.Jun 9 2021, 5:00 PM

bdrewery added inline comments.Jun 9 2021, 5:06 PM

sys/netpfil/pf/pf_ioctl.c
3774–3775	These `NULL` checks are dead code now with `M_WAITOK`.

Assume you meant to include only the sys/netpfil/pf/pf_ioctl.c changes?

In D30702#690012, @emaste wrote:

Assume you meant to include only the sys/netpfil/pf/pf_ioctl.c changes?

Gha, yes. I had a few local, uncommitted, changes, and apparently git-arc picked those up as well. And then helpfully removed them from my tree.

kp added a reviewer: network.Jun 9 2021, 6:03 PM

Remove unrelated changes
Don't check for NULL after M_WAITOK

Harbormaster completed remote builds in B39823: Diff 90654.Jun 9 2021, 6:37 PM

As far as I can check, all those changes are outside of the hold lock, so this is fine.

This revision is now accepted and ready to land.Jun 9 2021, 7:21 PM

Closed by commit rGea21980a3fac: pf: use M_WAITOK where possible (authored by kp). · Explain WhyJun 10 2021, 12:21 PM

This revision was automatically updated to reflect the committed changes.

kp added a commit: rGea21980a3fac: pf: use M_WAITOK where possible.

kp added a commit: rG3a57bb60f4ad: pf: use M_WAITOK where possible.Jun 17 2021, 2:56 PM

Revision Contents
Changeset List

Path

Size

sys/

netpfil/

pf/

pf_ioctl.c

78 lines

Diff 90695

View Options

pf: use M_WAITOK where possibleClosedPublicActions