Page MenuHomeFreeBSD
Differential D30670

tests/netgraph: Tests for ng_vlan_rotate
ClosedPublic
Actions

Authored by donner on Jun 7 2021, 1:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 20, 4:00 AM
Unknown Object (File)
Mar 20 2024, 11:10 PM
Unknown Object (File)
Mar 20 2024, 11:10 PM
Unknown Object (File)
Mar 20 2024, 11:09 PM
Unknown Object (File)
Mar 20 2024, 11:09 PM
Unknown Object (File)
Mar 20 2024, 11:09 PM
Unknown Object (File)
Mar 20 2024, 11:09 PM
Unknown Object (File)
Mar 20 2024, 11:09 PM
View All 69 Files
Subscribers
imp
melifaro

Details

Reviewers
kp
Group Reviewers
network
tests
Commits
rG7438333663b4: tests/netgraph: Tests for ng_vlan_rotate
rG617e33a19aaf: tests/netgraph: Tests for ng_vlan_rotate
rG053937ce6e1a: tests/netgraph: Tests for ng_vlan_rotate
rG6b08e68be111: tests/netgraph: Tests for ng_vlan_rotate
Summary

Test functionality of ng_vlan_rotate(4):

  • Rotate 1 to 9 stagged vlans in any possible direction and length
  • Rotate random combinations of ethertypes (8100, 88a8, 9100)
  • Provide too few or too many vlans
Test Plan
# kyua test vlan_rotate
vlan_rotate:basic  ->  passed  [4.400s]
vlan_rotate:ethertype  ->  passed  [1.087s]
vlan_rotate:minmax  ->  passed  [1.936s]
vlan_rotate:reverse  ->  passed  [4.401s]
vlan_rotate:typeether  ->  passed  [1.086s]

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 39797
Build 36686: arc lint + arc unit

Event Timeline

donner created this revision.Jun 7 2021, 1:18 PM
Herald added subscribers: melifaro, imp. · View Herald TranscriptJun 7 2021, 1:18 PM
donner requested review of this revision.Jun 7 2021, 1:18 PM
Harbormaster completed remote builds in B39762: Diff 90515.Jun 7 2021, 1:18 PM
donner added reviewers: network, tests.Jun 7 2021, 1:18 PM
donner updated this revision to Diff 90539.Jun 7 2021, 6:49 PM
  • Add reverse tests, going the other direction reverses the rotation
Harbormaster completed remote builds in B39773: Diff 90539.Jun 7 2021, 6:49 PM
donner updated this revision to Diff 90540.Jun 7 2021, 6:58 PM
  • Factor out common routines.
Harbormaster completed remote builds in B39774: Diff 90540.Jun 7 2021, 6:58 PM
donner edited the test plan for this revision. (Show Details)Jun 7 2021, 6:59 PM
donner updated this revision to Diff 90565.Jun 8 2021, 9:08 AM
  • Style fixes
Harbormaster completed remote builds in B39793: Diff 90565.Jun 8 2021, 9:08 AM
donner updated this revision to Diff 90577.Jun 8 2021, 11:40 AM

Rebase

Harbormaster completed remote builds in B39797: Diff 90577.Jun 8 2021, 11:40 AM
kp accepted this revision as: kp.Jun 8 2021, 4:00 PM
This revision is now accepted and ready to land.Jun 8 2021, 4:00 PM
donner added a parent revision: D30699: tests/netgraph: Factor out univeral data counter functions.Jun 8 2021, 8:00 PM
donner updated this revision to Diff 90606.Jun 8 2021, 9:06 PM
  • Test too few or too many vlans
This revision now requires review to proceed.Jun 8 2021, 9:06 PM
Harbormaster completed remote builds in B39813: Diff 90606.Jun 8 2021, 9:06 PM
donner edited the summary of this revision. (Show Details)Jun 8 2021, 9:08 PM
donner edited the test plan for this revision. (Show Details)
This revision was not accepted when it landed; it landed in state Needs Review.Jun 9 2021, 11:47 AM
Closed by commit rG6b08e68be111: tests/netgraph: Tests for ng_vlan_rotate (authored by donner). · Explain Why
This revision was automatically updated to reflect the committed changes.
donner added a commit: rG6b08e68be111: tests/netgraph: Tests for ng_vlan_rotate.
donner added a commit: rG053937ce6e1a: tests/netgraph: Tests for ng_vlan_rotate.Jun 16 2021, 11:27 AM
donner added a commit: rG617e33a19aaf: tests/netgraph: Tests for ng_vlan_rotate.Jun 16 2021, 11:46 AM
donner added a commit: rG7438333663b4: tests/netgraph: Tests for ng_vlan_rotate.Jun 16 2021, 12:04 PM

Revision Contents
Changeset List

PathSize
tests/
sys/
netgraph/
6 lines
268 lines

Diff 90577

View Options

tests/sys/netgraph/Makefile

Loading...
View Options

tests/sys/netgraph/vlan_rotate.c

Loading...