Differential D30676

LinuxKPI: fix sg_pcopy_from_buffer()
ClosedPublic
Actions

Authored by bz on Jun 7 2021, 3:16 PM.

Tags

None

Referenced Files

	F169295975: D30676.id90526.diff
	Tue, Sep 1, 3:46 AM

	F169286274: D30676.id91072.diff
	Tue, Sep 1, 3:24 AM

	Unknown Object (File)
	Sun, Aug 30, 2:10 PM

	Unknown Object (File)
	Sun, Aug 30, 9:46 AM

	Unknown Object (File)
	Wed, Aug 26, 1:33 PM

	Unknown Object (File)
	Tue, Aug 25, 8:00 PM

	Unknown Object (File)
	Tue, Aug 25, 12:45 PM

	Unknown Object (File)
	Tue, Aug 25, 12:36 PM

Subscribers

Details

Reviewers

Group Reviewers

Commits

rGd2c8c4d15a6e: LinuxKPI: fix sg_pcopy_from_buffer()
rGedfcdffefc16: LinuxKPI: fix sg_pcopy_from_buffer()

Summary

In sg_pcopy_from_buffer() is an error in that skip can underflow
and lead to bogus page arithmetics which may lead to memory corruption
or more likely panics. Once we found a s/g page to copy into there
is nothing to skip anymore so simply set skip to 0.

Sponsored by: The FreeBSD Foundation
MFC after: 5 days

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 39770
Build 36659: arc lint + arc unit

Event Timeline

bz created this revision.Jun 7 2021, 3:16 PM

Herald added subscribers: emaste, imp. · View Herald TranscriptJun 7 2021, 3:16 PM

bz requested review of this revision.Jun 7 2021, 3:16 PM

Harbormaster completed remote builds in B39770: Diff 90526.Jun 7 2021, 3:16 PM

• hselasky accepted this revision.Jun 7 2021, 4:05 PM

This revision is now accepted and ready to land.Jun 7 2021, 4:05 PM

Don't forget to MFC this change.

Closed by commit rGedfcdffefc16: LinuxKPI: fix sg_pcopy_from_buffer() (authored by bz). · Explain WhyJun 18 2021, 9:49 PM

This revision was automatically updated to reflect the committed changes.

bz added a commit: rGedfcdffefc16: LinuxKPI: fix sg_pcopy_from_buffer().

bz added a commit: rGd2c8c4d15a6e: LinuxKPI: fix sg_pcopy_from_buffer().Jul 18 2021, 12:39 AM

Revision Contents
Changeset List

Path

Size

sys/

compat/

linuxkpi/

common/

include/

linux/

3 lines

Diff 90526

sys/compat/linuxkpi/common/include/linux/scatterlist.h

Loading...