The old thread priority must be stored as part of the EPOCH(9) tracker.
ClosedPublic
Actions

Authored by • hselasky on May 21 2021, 9:29 AM.

Details

Reviewers

markj
glebius
mmacy
kib

Commits

rGc64d1bd7145b: The old thread priority must be stored as part of the EPOCH(9) tracker.
rGef0f7ae934b0: The old thread priority must be stored as part of the EPOCH(9) tracker.

Summary

Else recursive use of EPOCH(9) may cause the wrong priority to be restored.

MFC after: 1 week
Sponsored by: Mellanox Technologies // NVIDIA Networking

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• hselasky requested review of this revision.May 21 2021, 9:29 AM

• hselasky created this revision.

Added patch context.

I forgot that I wrote this, which does priority propagation properly: https://reviews.freebsd.org/D24622

I will try to revisit it shortly. I think this change is ok in the meantime.

sys/sys/param.h
79	Because of the removal of a field from struct thread? In this case the change should not be MFCed. In practice it doesn't matter because the layout will not change due to alignment constraints. There will be some pad bytes between `td_base_user_pri` and `td_rb_list`. So in fact __FreeBSD_version does not need to be bumped at all.

In D30375#682598, @markj wrote:

I forgot that I wrote this, which does priority propagation properly: https://reviews.freebsd.org/D24622

I will try to revisit it shortly. I think this change is ok in the meantime.

Looks good. I'll have a closer look over the weekend.

--HPS