arm64: log vm_fault error for data_abort
ClosedPublic
Actions

Authored by bz on May 20 2021, 4:58 PM.

Details

Reviewers

andrew
manu

Commits

rGfbf75b113edc: arm64: log vm_fault error for data_abort

Summary

Log the vm_fault() error in the data_abort panic so it is easier to
find the reason vm_fault() failed (e.g., invalid address).

Reviewed by: ..
MFC After: 2 weeks
Differential Revision: ...

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 39314
Build 36203: arc lint + arc unit

Event Timeline

bz created this revision.May 20 2021, 4:58 PM

Herald added a reviewer: manu. · View Herald TranscriptMay 20 2021, 4:58 PM

Herald added subscribers: emaste, imp. · View Herald Transcript

bz requested review of this revision.May 20 2021, 4:58 PM

Harbormaster completed remote builds in B39314: Diff 89541.May 20 2021, 4:58 PM

We could drop printing frame->tf_elr as we already do so in print_registers

This revision is now accepted and ready to land.May 24 2021, 8:31 AM

In D30362#683175, @andrew wrote:

We could drip printing frame->tf_elr as we already do so in print_registers

That brings me to a different question: print_registers and a "show reg" in ddb right after the panic result in two different outputs. Is that intentional?

They are printing different trap frames. print_registers will print the fault frame while show reg will print a frame from a breakpoint within panic. The registers seen when debugger_on_trap is true should be identical to the version printed by print_registers.

In D30362#683320, @andrew wrote:

They are printing different trap frames. print_registers will print the fault frame while show reg will print a frame from a breakpoint within panic. The registers seen when debugger_on_trap is true should be identical to the version printed by print_registers.

Thank you; Let's keep the ELR in the panicstr then.

Closed by commit rGfbf75b113edc: arm64: log vm_fault error for data_abort (authored by bz). · Explain WhyMay 24 2021, 10:13 PM

This revision was automatically updated to reflect the committed changes.

bz added a commit: rGfbf75b113edc: arm64: log vm_fault error for data_abort.