Page MenuHomeFreeBSD
Differential D30253

libalias: replace placeholder with static constant
ClosedPublic
Actions

Authored by donner on May 13 2021, 9:50 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jan 8, 12:10 PM
Unknown Object (File)
Wed, Jan 8, 12:08 PM
Unknown Object (File)
Wed, Jan 8, 11:59 AM
Unknown Object (File)
Wed, Jan 8, 11:11 AM
Unknown Object (File)
Tue, Jan 7, 6:59 PM
Unknown Object (File)
Tue, Jan 7, 12:08 PM
Unknown Object (File)
Thu, Dec 26, 10:55 AM
Unknown Object (File)
Tue, Dec 24, 10:08 AM
View All 96 Files
Subscribers
imp
melifaro
Contributor Reviews (src)

Details

Reviewers
• hselasky
emaste
eugen_grosbein.net
Group Reviewers
network
Commits
rG6a1b3e91539d: libalias: replace placeholder with static constant
rG16adf789ba68: libalias: replace placeholder with static constant
rG189f8eea138a: libalias: replace placeholder with static constant
Summary

The field nullAddress in struct libalias is never set and never used.
It exists as a placeholder for an unused argument only.

Test Plan

Just recompile everything.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 39188
Build 36077: arc lint + arc unit

Event Timeline

donner created this revision.May 13 2021, 9:50 PM
Herald added subscribers: Contributor Reviews (src), melifaro, imp. · View Herald TranscriptMay 13 2021, 9:50 PM
donner requested review of this revision.May 13 2021, 9:50 PM
Harbormaster completed remote builds in B39174: Diff 89166.May 13 2021, 9:50 PM
donner added reviewers: network, • hselasky, emaste, eugen_grosbein.net.May 13 2021, 9:55 PM
• hselasky added inline comments.May 14 2021, 8:45 AM
sys/netinet/libalias/alias_db.c
227

Should it be:
static const struct in_addr ???

donner updated this revision to Diff 89186.May 14 2021, 9:14 AM
  • Silence warning about non-static declaration.
Harbormaster completed remote builds in B39185: Diff 89186.May 14 2021, 9:15 AM
donner marked an inline comment as done.May 14 2021, 9:16 AM
donner added inline comments.
sys/netinet/libalias/alias_db.c
227

The compiler had the same question. Thank you for spotting this.

• hselasky added inline comments.May 14 2021, 10:26 AM
sys/netinet/libalias/alias_db.c
229

Should you also add "const" keyword here?

donner updated this revision to Diff 89210.May 14 2021, 1:21 PM
donner marked an inline comment as done.
  • Make it const.
Harbormaster completed remote builds in B39188: Diff 89210.May 14 2021, 1:22 PM
donner marked an inline comment as done.May 14 2021, 1:23 PM

Rebased to D30259

sys/netinet/libalias/alias_db.c
229

You are right. Added const.

donner added a parent revision: D30259: libalias: Style cleanup.May 14 2021, 1:23 PM
• hselasky accepted this revision.May 14 2021, 2:16 PM

Looks good.

This revision is now accepted and ready to land.May 14 2021, 2:16 PM
Closed by commit rG189f8eea138a: libalias: replace placeholder with static constant (authored by donner). · Explain WhyMay 15 2021, 7:09 AM
This revision was automatically updated to reflect the committed changes.
donner marked an inline comment as done.
donner added a commit: rG189f8eea138a: libalias: replace placeholder with static constant.
donner added a commit: rG16adf789ba68: libalias: replace placeholder with static constant.May 30 2021, 1:50 PM
donner added a commit: rG6a1b3e91539d: libalias: replace placeholder with static constant.May 30 2021, 8:04 PM

Revision Contents
Changeset List

PathSize
sys/
netinet/
libalias/
24 lines
2 lines

Diff 89210

View Options

sys/netinet/libalias/alias_db.c

Loading...
View Options

sys/netinet/libalias/alias_local.h

Loading...