Page MenuHomeFreeBSD

libalias: replace placeholder with static constant
ClosedPublic

Authored by donner on May 13 2021, 9:50 PM.

Details

Summary

The field nullAddress in struct libalias is never set and never used.
It exists as a placeholder for an unused argument only.

Test Plan

Just recompile everything.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

sys/netinet/libalias/alias_db.c
226

Should it be:
static const struct in_addr ???

  • Silence warning about non-static declaration.
donner added inline comments.
sys/netinet/libalias/alias_db.c
226

The compiler had the same question. Thank you for spotting this.

sys/netinet/libalias/alias_db.c
228

Should you also add "const" keyword here?

donner marked an inline comment as done.
  • Make it const.

Rebased to D30259

sys/netinet/libalias/alias_db.c
228

You are right. Added const.

This revision is now accepted and ready to land.May 14 2021, 2:16 PM
This revision was automatically updated to reflect the committed changes.
donner marked an inline comment as done.