Differential D28947

[POWERPC] Switch endian of common dev information
ClosedPublic
Actions

Authored by leonardo.bianconi_eldorado.org.br on Feb 26 2021, 6:22 PM.

Tags

Referenced Files

	F106106557: D28947.diff
	Wed, Dec 25, 12:25 PM

	Unknown Object (File)
	Mon, Dec 9, 3:42 AM

	Unknown Object (File)
	Thu, Dec 5, 9:51 PM

	Unknown Object (File)
	Wed, Dec 4, 11:43 AM

	Unknown Object (File)
	Thu, Nov 28, 11:19 PM

	Unknown Object (File)
	Nov 25 2024, 12:13 PM

	Unknown Object (File)
	Nov 14 2024, 9:15 AM

	Unknown Object (File)
	Nov 14 2024, 7:05 AM

View All 85 Files

Subscribers

lffpires_ruabrasil.org

Contributor Reviews (src)

Details

Reviewers

bryanv
alfredo

Commits

rG7e583075a411: virtio-modern: fix PCI common read/write functions on big endian targets
rGfb53b42e36a9: virtio-modern: fix PCI common read/write functions on big endian targets

Summary

Virtio modern has the common data organized in little endian.
POWERPC architecture, as BE, was reading and writing in the wrong
format.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

leonardo.bianconi_eldorado.org.br created this revision.Feb 26 2021, 6:22 PM

Herald added subscribers: Contributor Reviews (src), lffpires_ruabrasil.org, imp. · View Herald TranscriptFeb 26 2021, 6:22 PM

Harbormaster completed remote builds in B37416: Diff 84758.Feb 26 2021, 6:22 PM

leonardo.bianconi_eldorado.org.br requested review of this revision.Feb 26 2021, 6:22 PM

[POWERPC] Switch endian of common dev information

Virtio modern has the common data organized in little endian.
POWERPC architecture, as BE, was reading and writing in the wrong
format.

Checking endian when reading and writing in dev common.

Harbormaster completed remote builds in B37578: Diff 85147.Mar 4 2021, 4:49 PM

leonardo.bianconi_eldorado.org.br added a reviewer: bryanv.Mar 4 2021, 7:26 PM

leonardo.bianconi_eldorado.org.br added a reviewer: alfredo.

alfredo added a parent revision: D28012: [POWERPC] add bus_map_resource and bus_unmap_resource DEVMETHODs.Mar 8 2021, 10:00 PM

alfredo added a project: PowerPC.

Herald added subscribers: luporl, bdragon. · View Herald TranscriptMar 8 2021, 10:01 PM

bryanv requested changes to this revision.Mar 8 2021, 10:38 PM

bryanv added inline comments.

sys/dev/virtio/pci/virtio_pci_modern.c
149	This method signature of void pointer and size is too easy to get wrong, difficult to read, and really only makes sense as a DEVMETHOD to avoid interface explosion. Add methods for each size like already exists instead.

This revision now requires changes to proceed.Mar 8 2021, 10:38 PM

Avoid creating new function and convert endian in existing functions.

Harbormaster completed remote builds in B37741: Diff 85507.Mar 10 2021, 8:18 PM

leonardo.bianconi_eldorado.org.br marked an inline comment as done.Mar 10 2021, 8:19 PM

leonardo.bianconi_eldorado.org.br added inline comments.

sys/dev/virtio/pci/virtio_pci_modern.c
149	I've added the call to convert endian inside existing functions, avoiding the new one created before.

leonardo.bianconi_eldorado.org.br marked an inline comment as done.Mar 25 2021, 12:59 PM

leonardo.bianconi_eldorado.org.br added inline comments.

sys/dev/virtio/pci/virtio_pci_modern.c
149	@bryanv I have added the endian change inside the existent functions, to be generic, since I didn't identify any call to these functions outside this file. If you prefer to create specific functions for these calls, I can change it, let me know. Thanks!

Thanks Leonardo. I've being testing this patch, it looks good to me.

@bryanv, are you ok with this change?

bryanv accepted this revision.May 4 2021, 2:54 PM

This revision is now accepted and ready to land.May 4 2021, 2:54 PM

Closed by commit rGfb53b42e36a9: virtio-modern: fix PCI common read/write functions on big endian targets (authored by alfredo). · Explain WhyMay 7 2021, 2:55 AM

This revision was automatically updated to reflect the committed changes.

alfredo added a commit: rGfb53b42e36a9: virtio-modern: fix PCI common read/write functions on big endian targets.

alfredo added a commit: rG7e583075a411: virtio-modern: fix PCI common read/write functions on big endian targets.Aug 30 2021, 1:15 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

virtio/

pci/

virtio_pci_modern.c

12 lines

Diff 88769

sys/dev/virtio/pci/virtio_pci_modern.c

Loading...