Details

Reviewers

bdrewery
des
allanjude

Summary

Original commits:
db58a8e40ce0ed8b27d51fd274ab609b18d74273 by des
c6de6086cfc759413dd95b5fa549fe7eebca801a by emaste

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

emaste requested review of this revision.Apr 23 2021, 6:59 PM

emaste created this revision.

I guess, the man pages also need their default version string updated?

allanjude added a subscriber: allanjude.Apr 25 2021, 2:10 PM

allanjude added inline comments.

kex.c
1192 ↗	(On Diff #88056)	is this not redundant now? as above on line 1188, if `*version_addendum == '\0'` it sets `version_addendum = NULL;`
ssh.c
891–898
ssh_config
47	Does this date need bumping?
ssh_config.5
1882	We should sync this default
sshd.c
903–910

Updates from @allanjude

I guess, the man pages also need their default version string updated?

Yes, all instances should be updated at commit time. I've used 2021XXXX as a placeholder for now.

emaste added a reviewer: allanjude.Apr 25 2021, 3:22 PM

rebase to accommodate upstream changes

style from @allanjude

emaste added inline comments.Aug 31 2021, 5:40 PM

kex.c
1192 ↗	(On Diff #88056)	Yes, I think this came out of upstream implementing this differently, reverting locally.

Incorporate more feedback from @allanjude

This is still in the tree today, but propose retiring it in D32930

emaste mentioned this in rG613b4b79713e: ssh: apply style(9) to version_addendum.Apr 18 2022, 10:15 PM

emaste mentioned this in rGd47ac32b4a4f: ssh: apply style(9) to version_addendum.Apr 25 2022, 1:05 AM

emaste mentioned this in rG776b9127edb1: ssh: apply style(9) to version_addendum.

emaste added a child revision: D29952: ssh-agent: Add -x option to exit when all clients have disconnected.Dec 13 2022, 6:10 PM

emaste added a parent revision: D29954: sshd: Add blocklistd support.

ssh, sshd: Add the VersionAddendum configuration variable
Needs ReviewPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 88117

readconf.h

readconf.c

servconf.c

ssh.1

ssh.c

ssh_config

ssh_config.5

sshconnect.c

sshd.c

sshd_config

sshd_config.5

version.h

ssh, sshd: Add the VersionAddendum configuration variableNeeds ReviewPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 88117

readconf.h

readconf.c

servconf.c

ssh.1

ssh.c

ssh_config

ssh_config.5

sshconnect.c

sshd.c

sshd_config

sshd_config.5

version.h

ssh, sshd: Add the VersionAddendum configuration variable
Needs ReviewPublic
Actions

Revision Contents
Changeset List