Page MenuHomeFreeBSD

ssh, sshd: Add the VersionAddendum configuration variable
Needs ReviewPublic

Authored by emaste on Apr 23 2021, 6:59 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 25, 1:52 AM
Unknown Object (File)
Sat, Nov 23, 10:38 AM
Unknown Object (File)
Fri, Nov 22, 2:24 PM
Unknown Object (File)
Thu, Nov 21, 7:38 AM
Unknown Object (File)
Thu, Nov 21, 6:36 AM
Unknown Object (File)
Tue, Nov 19, 11:16 PM
Unknown Object (File)
Fri, Nov 15, 6:50 PM
Unknown Object (File)
Fri, Nov 8, 2:04 AM
Subscribers

Details

Summary

Original commits:
db58a8e40ce0ed8b27d51fd274ab609b18d74273 by des
c6de6086cfc759413dd95b5fa549fe7eebca801a by emaste

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

emaste created this revision.

I guess, the man pages also need their default version string updated?

allanjude added inline comments.
kex.c
1192 ↗(On Diff #88056)

is this not redundant now? as above on line 1188, if *version_addendum == '\0' it sets version_addendum = NULL;

ssh.c
874–881
ssh_config
47

Does this date need bumping?

ssh_config.5
1966

We should sync this default

sshd.c
906–913
emaste marked an inline comment as done.

Updates from @allanjude

I guess, the man pages also need their default version string updated?

Yes, all instances should be updated at commit time. I've used 2021XXXX as a placeholder for now.

rebase to accommodate upstream changes

kex.c
1192 ↗(On Diff #88056)

Yes, I think this came out of upstream implementing this differently, reverting locally.

This is still in the tree today, but propose retiring it in D32930