Page MenuHomeFreeBSD

openssh: consolidate some globally-applicable flags
Needs ReviewPublic

Authored by kevans on Fri, Sep 10, 5:22 AM.

Details

Reviewers
emaste
des
Summary

Pretty much all applications/libs built out of openssh define a common
set of options:

  • HAVE_LDNS is only relevant for applications that build readconf.c and

libssh, which builds getrrsetbyname off of ldns, but defining it is more
future-proof.

  • All of them include ssh_namespace.h, and include out of

crypto/openssh.

Moving these into crypto/openssh reduces the boilerplate and gives us
a central place if we run into other options like HAVE_LDNS.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 41592
Build 38481: arc lint + arc unit

Event Timeline

Moving these into crypto/openssh

Yes, although it is somewhat odd that the build infrastructure is now split between secure/* and crypto/openssh/

crypto/openssh/Makefile.freebsd
12–13 ↗(On Diff #94938)

I think the real reason is to accommodate WITH_/WITHOUT_LDNS src.conf setting. Perhaps we should do the same with LIBWRAP from secure/usr.sbin/sshd/Makefile?

crypto/openssh/Makefile.freebsd
12–13 ↗(On Diff #94938)

Ah, good point; will do. I'll move this guy to secure/Makefile.openssh or something as well...