Page MenuHomeFreeBSD
Differential D29834

linkat(2): check NIRES_EMPTYPATH on the first fd arg
ClosedPublic
Actions

Authored by kib on Apr 19 2021, 1:38 PM.
Tags
None
Referenced Files
F165346747: D29834.id87715.diff
Fri, Aug 7, 6:35 PM
F165305257: D29834.diff
Fri, Aug 7, 1:19 PM
F165247359: D29834.id87727.diff
Fri, Aug 7, 3:56 AM
Unknown Object (File)
Tue, Jul 21, 2:39 PM
Unknown Object (File)
Jun 15 2026, 3:32 PM
Unknown Object (File)
May 11 2026, 2:05 AM
Unknown Object (File)
May 11 2026, 2:02 AM
Unknown Object (File)
May 11 2026, 2:02 AM
View All Files
Subscribers
None

Details

Reviewers
arichardson
markj
Commits
rG578c26f31c0c: linkat(2): check NIRES_EMPTYPATH on the first fd arg

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kib requested review of this revision.Apr 19 2021, 1:38 PM
kib created this revision.
markj added inline comments.Apr 19 2021, 1:47 PM
sys/kern/vfs_syscalls.c
1581

How can it be null? kern_linkat_vp() dereferences nd.ni_vp unconditionally.

markj accepted this revision.Apr 19 2021, 1:51 PM
This revision is now accepted and ready to land.Apr 19 2021, 1:51 PM
kib marked an inline comment as done.Apr 19 2021, 3:02 PM
kib added inline comments.
sys/kern/vfs_syscalls.c
1581

Yes, LOOKUP only returns success when there is something to lookup.

kib updated this revision to Diff 87715.Apr 19 2021, 3:03 PM
kib marked an inline comment as done.

Remove ni_vp != NULL check.

This revision now requires review to proceed.Apr 19 2021, 3:03 PM
markj accepted this revision.Apr 19 2021, 3:04 PM
This revision is now accepted and ready to land.Apr 19 2021, 3:04 PM
Closed by commit rG578c26f31c0c: linkat(2): check NIRES_EMPTYPATH on the first fd arg (authored by kib). · Explain WhyApr 19 2021, 6:32 PM
This revision was automatically updated to reflect the committed changes.
kib added a commit: rG578c26f31c0c: linkat(2): check NIRES_EMPTYPATH on the first fd arg.

Revision Contents
Changeset List

PathSize
sys/
kern/
24 lines

Diff 87727

View Options

sys/kern/vfs_syscalls.c

Loading...