Page MenuHomeFreeBSD

linkat(2): check NIRES_EMPTYPATH on the first fd arg
ClosedPublic

Authored by kib on Apr 19 2021, 1:38 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 7 2024, 10:37 AM
Unknown Object (File)
Jan 22 2024, 6:43 AM
Unknown Object (File)
Jan 12 2024, 2:46 AM
Unknown Object (File)
Dec 23 2023, 12:11 AM
Unknown Object (File)
Nov 25 2023, 12:18 PM
Unknown Object (File)
Nov 22 2023, 9:23 PM
Unknown Object (File)
Nov 22 2023, 1:28 PM
Unknown Object (File)
Nov 22 2023, 1:21 PM
Subscribers
None

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

kib requested review of this revision.Apr 19 2021, 1:38 PM
kib created this revision.
sys/kern/vfs_syscalls.c
1581

How can it be null? kern_linkat_vp() dereferences nd.ni_vp unconditionally.

This revision is now accepted and ready to land.Apr 19 2021, 1:51 PM
kib marked an inline comment as done.Apr 19 2021, 3:02 PM
kib added inline comments.
sys/kern/vfs_syscalls.c
1581

Yes, LOOKUP only returns success when there is something to lookup.

kib marked an inline comment as done.

Remove ni_vp != NULL check.

This revision now requires review to proceed.Apr 19 2021, 3:03 PM
This revision is now accepted and ready to land.Apr 19 2021, 3:04 PM