Page MenuHomeFreeBSD
Differential D29525

AMD-vi: Fortify IVHD device_identify process
ClosedPublic
Actions

Authored by khng on Apr 1 2021, 12:13 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 9, 9:46 PM
Unknown Object (File)
Sun, Feb 23, 10:48 PM
Unknown Object (File)
Feb 17 2025, 1:01 AM
Unknown Object (File)
Feb 4 2025, 10:27 PM
Unknown Object (File)
Jan 22 2025, 2:24 PM
Unknown Object (File)
Jan 18 2025, 3:12 PM
Unknown Object (File)
Jan 18 2025, 1:34 AM
Unknown Object (File)
Jan 15 2025, 1:11 PM
View All 99 Files
Subscribers
bcran
imp
rgrimes

Details

Reviewers
grehan
philip
lwhsu
Group Reviewers
bhyve
Commits
rGf8b5f7426f0f: AMD-vi: Fortify IVHD device_identify process
rG6e2fc728d8da: AMD-vi: Fortify IVHD device_identify process
rG6fe60f1d5c39: AMD-vi: Fortify IVHD device_identify process
Summary
  • Use malloc(9) to allocate ivhd_hdrs list. The previous assumption that there are at most 10 IVHDs in a system is not true. A counter example would be a system with 4 IOMMUs, and each IOMMU is related to IVHDs type 10h, 11h and 40h in the ACPI IVRS table.
  • Always scan through the whole ivhd_hdrs list to find IVHDs that has the same DeviceId but less prioritized IVHD type.

Sponsored by: The FreeBSD Foundation
MFC with: 74ada297e897

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
sys/
amd64/
vmm/
amd/
47 lines

Diff 87682

View Options

sys/amd64/vmm/amd/ivrs_drv.c

Context not available.
struct in6_addr clat_prefix; /* Client (CLAT) prefix */ struct in6_addr clat_prefix; /* Client (CLAT) prefix */
uint8_t plat_plen; /* PLAT Prefix length */ uint8_t plat_plen; /* PLAT Prefix length */
uint8_t clat_plen; /* CLAT Prefix length */ uint8_t clat_plen; /* CLAT Prefix length */
uint8_t clat_local; /* CLAT UE parameter */
donnerUnsubmitted
Not Done
Inline Actions

Adding a new value into the struct causes an ABI break.
Adding a new flag to the existing flags variable (below), maintains backward compatibility.

donner: Adding a new value into the struct causes an ABI break. Adding a new flag to the existing flags…
uint8_t set; /* Named instance set [0..31] */ uint8_t set; /* Named instance set [0..31] */
uint8_t spare; uint8_t spare;
uint32_t flags; uint32_t flags;
Context not available.