Page MenuHomeFreeBSD
Differential D29108

linux: support AT_EMPTY_PATH flag in fchownat(2)
ClosedPublic
Actions

Authored by trasz on Mar 6 2021, 8:04 PM.
Tags
None
Referenced Files
F161153203: D29108.diff
Wed, Jul 1, 1:09 AM
Unknown Object (File)
Sun, Jun 28, 11:44 PM
Unknown Object (File)
Tue, Jun 16, 12:39 PM
Unknown Object (File)
Mon, Jun 15, 6:16 PM
Unknown Object (File)
Mon, Jun 15, 5:11 PM
Unknown Object (File)
Mon, Jun 15, 4:35 PM
Unknown Object (File)
Mon, Jun 15, 4:01 PM
Unknown Object (File)
Mon, Jun 15, 3:52 PM
View All Files
Subscribers
imp

Details

Reviewers
kib
Group Reviewers
Linux Emulation
Commits
rG1e44a4ea0d4a: linux: support AT_EMPTY_PATH flag in fchownat(2)
rGe47823b8312b: linux: support AT_EMPTY_PATH flag in fchownat(2)
Summary

This fixes rsyslog package installation scripts in Bionic.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 38589
Build 35478: arc lint + arc unit

Event Timeline

trasz created this revision.Mar 6 2021, 8:04 PM
Herald added a subscriber: imp. · View Herald TranscriptMar 6 2021, 8:04 PM
trasz requested review of this revision.Mar 6 2021, 8:04 PM
Harbormaster completed remote builds in B37642: Diff 85280.Mar 6 2021, 8:05 PM
trasz added reviewers: Linux Emulation, kib.Mar 6 2021, 8:06 PM
kib added a comment.Mar 6 2021, 8:32 PM

I think the flag should be implemented on the FreeBSD side.

Also, your patch does not handle AT_FDCWD case, that is described in the Linux man page.

sys/compat/linux/linux_file.c
1741–1742

You broke detection of the unknown flags.

trasz updated this revision to Diff 85291.Mar 7 2021, 11:59 AM

Fix unknown flag detection, detect AT_FDCWD.

Harbormaster completed remote builds in B37649: Diff 85291.Mar 7 2021, 12:00 PM
trasz added a comment.EditedMar 7 2021, 12:02 PM

I've considered doing it natively first - that would allow us to support AT_FDCWD with AT_EMPTY_PATH - but after a few hours I gave up. I'd strongly prefer committing this small change instead of making another attempt at understanding namei().

trasz updated this revision to Diff 85292.Mar 7 2021, 12:04 PM

Fix warning message.

Harbormaster completed remote builds in B37650: Diff 85292.Mar 7 2021, 12:04 PM
trasz added a comment.Mar 8 2021, 3:26 PM

(Tinderboxed.)

trasz updated this revision to Diff 87480.Apr 15 2021, 12:27 PM

Reimplement.

Harbormaster completed remote builds in B38589: Diff 87480.Apr 15 2021, 12:27 PM
kib accepted this revision.Apr 15 2021, 12:46 PM

BTW there are more Linux syscalls taking AT_EMPTY_PATH

sys/compat/linux/linux_file.c
1751

Extra ()

This revision is now accepted and ready to land.Apr 15 2021, 12:46 PM
trasz added inline comments.Apr 15 2021, 12:51 PM
sys/compat/linux/linux_file.c
1751

This is copy/pasted all over the tree; I'll fix it in a later sweep.

trasz added a comment.Apr 16 2021, 9:55 AM

(Tinderboxed.)

Closed by commit rGe47823b8312b: linux: support AT_EMPTY_PATH flag in fchownat(2) (authored by trasz). · Explain WhyApr 16 2021, 3:29 PM
This revision was automatically updated to reflect the committed changes.
trasz added a commit: rGe47823b8312b: linux: support AT_EMPTY_PATH flag in fchownat(2).
trasz added a commit: rG1e44a4ea0d4a: linux: support AT_EMPTY_PATH flag in fchownat(2).Feb 17 2022, 10:56 AM

Revision Contents
Changeset List

PathSize
sys/
compat/
linux/
9 lines

Diff 87480

View Options

sys/compat/linux/linux_file.c

Loading...