Differential D29328

Unbreak MSG_CMSG_CLOEXEC
ClosedPublic
Actions

Authored by arichardson on Mar 18 2021, 5:33 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Sep 6, 7:22 PM

	Unknown Object (File)
	Sun, Sep 6, 3:37 PM

	Unknown Object (File)
	Sun, Sep 6, 1:41 PM

	Unknown Object (File)
	Sun, Sep 6, 10:35 AM

	Unknown Object (File)
	Sat, Sep 5, 8:31 PM

	Unknown Object (File)
	Sat, Sep 5, 3:54 AM

	Unknown Object (File)
	Fri, Sep 4, 6:25 PM

	Unknown Object (File)
	Thu, Sep 3, 10:22 PM

Subscribers

Details

Reviewers

mjg
kib
jilles

Commits

rG7962978754d3: Unbreak MSG_CMSG_CLOEXEC
rG6ceacebdf522: Unbreak MSG_CMSG_CLOEXEC

Summary

MSG_CMSG_CLOEXEC has not been working since 2015 (SVN r284380) because
_finstall expects O_CLOEXEC and not UF_EXCLOSE as the flags argument.
This was probably not noticed because we don't have a test for this flag
so this commit adds one. I found this problem because one of the
libwayland tests was failing.

Fixes: ea31808c3b07 ("fd: move out actual fp installation to _finstall")

Test Plan

Newly added test failed before, passes now.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 37917
Build 34806: arc lint + arc unit

Event Timeline

arichardson created this revision.Mar 18 2021, 5:33 PM

Herald added a subscriber: imp. · View Herald TranscriptMar 18 2021, 5:33 PM

arichardson requested review of this revision.Mar 18 2021, 5:33 PM

Harbormaster completed remote builds in B37917: Diff 85972.Mar 18 2021, 5:34 PM

mjg accepted this revision.Mar 18 2021, 6:00 PM

This revision is now accepted and ready to land.Mar 18 2021, 6:00 PM

kib accepted this revision.Mar 18 2021, 6:10 PM

Closed by commit rG6ceacebdf522: Unbreak MSG_CMSG_CLOEXEC (authored by arichardson). · Explain WhyMar 18 2021, 8:53 PM

This revision was automatically updated to reflect the committed changes.

arichardson added a commit: rG6ceacebdf522: Unbreak MSG_CMSG_CLOEXEC.

arichardson added a commit: rG7962978754d3: Unbreak MSG_CMSG_CLOEXEC.Apr 10 2021, 1:30 PM

Revision Contents
Changeset List

Path

Size

sys/

kern/

2 lines

tests/

sys/

kern/

unix_passfd_test.c

45 lines

Diff 85972

sys/kern/uipc_usrreq.c

Loading...

tests/sys/kern/unix_passfd_test.c

Loading...