Page MenuHomeFreeBSD
Differential D28711

aarch64: Clear TLS registers during exec().
ClosedPublic
Actions

Authored by jhb on Feb 16 2021, 6:52 PM.
Tags
None
Referenced Files
F103480973: D28711.diff
Mon, Nov 25, 2:13 PM
Unknown Object (File)
Sun, Nov 24, 3:12 PM
Unknown Object (File)
Thu, Nov 21, 3:37 PM
Unknown Object (File)
Sun, Nov 17, 8:47 PM
Unknown Object (File)
Tue, Nov 12, 8:12 AM
Unknown Object (File)
Tue, Nov 12, 8:03 AM
Unknown Object (File)
Sat, Nov 9, 2:19 PM
Unknown Object (File)
Sat, Nov 9, 12:26 PM
View All 84 Files
Subscribers
arichardson
emaste
imp

Details

Reviewers
andrew
manu
Group Reviewers
arm64
Commits
rG0723b409150a: aarch64: Clear TLS registers during exec().
Summary

These are not stored in the trapframe so must be cleared explicitly.

This is similar to one of the MIPS changes in 822d2d6ac94f.

Sponsored by: DARPA

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 37876
Build 34765: arc lint + arc unit

Event Timeline

jhb created this revision.Feb 16 2021, 6:52 PM
Herald added a reviewer: manu. · View Herald TranscriptFeb 16 2021, 6:52 PM
Herald added subscribers: emaste, imp. · View Herald Transcript
Harbormaster completed remote builds in B37061: Diff 84028.Feb 16 2021, 6:52 PM
jhb requested review of this revision.Feb 16 2021, 6:52 PM
andrew added inline comments.Mar 4 2021, 6:13 PM
sys/arm64/arm64/machdep.c
566–567

Does td == curthread always hold here?

andrew added a reviewer: arm64.Mar 4 2021, 6:14 PM
arichardson added a subscriber: arichardson.Mar 4 2021, 6:18 PM
arichardson added a comment.Mar 4 2021, 7:32 PM

Do we need this for linux_exec_setregs?

jhb added inline comments.Mar 9 2021, 9:51 PM
sys/arm64/arm64/machdep.c
566–567

Yes.

jhb added a comment.Mar 9 2021, 9:52 PM
In D28711#651003, @arichardson wrote:

Do we need this for linux_exec_setregs?

Hmm, possibly.

jhb updated this revision to Diff 85860.Mar 16 2021, 11:17 PM
  • Cleared in linux_exec_setregs().
Harbormaster completed remote builds in B37876: Diff 85860.Mar 16 2021, 11:17 PM
andrew accepted this revision.Mar 17 2021, 9:15 AM
This revision is now accepted and ready to land.Mar 17 2021, 9:15 AM
Closed by commit rG0723b409150a: aarch64: Clear TLS registers during exec(). (authored by jhb). · Explain WhyMar 17 2021, 8:20 PM
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rG0723b409150a: aarch64: Clear TLS registers during exec()..

Revision Contents
Changeset List

PathSize
sys/
arm64/
arm64/
5 lines
linux/
5 lines

Diff 85860

View Options

sys/arm64/arm64/machdep.c

Loading...
View Options

sys/arm64/linux/linux_sysvec.c

Loading...