Page MenuHomeFreeBSD
Differential D28974

filt_fsevent: only record interested events
ClosedPublic
Actions

Authored by rew on Feb 27 2021, 7:47 PM.
Tags
None
Referenced Files
F159122222: D28974.id85006.diff
Wed, Jun 10, 8:59 AM
F159118295: D28974.id.diff
Wed, Jun 10, 7:59 AM
Unknown Object (File)
Sun, Jun 7, 5:36 PM
Unknown Object (File)
Fri, Jun 5, 7:53 AM
Unknown Object (File)
Sat, May 30, 10:49 AM
Unknown Object (File)
Tue, May 26, 8:36 PM
Unknown Object (File)
Tue, May 26, 8:35 PM
Unknown Object (File)
Mon, May 18, 9:17 AM
View All Files
Subscribers
imp

Details

Reviewers
kib
Commits
rG0cc746f19352: filt_fsevent: only record interested events
Summary

Previously, all EVFILT_FS events that were triggered, were also
activated.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 37443
Build 34332: arc lint + arc unit

Event Timeline

rew created this revision.Feb 27 2021, 7:47 PM
Herald added a subscriber: imp. · View Herald TranscriptFeb 27 2021, 7:47 PM
rew requested review of this revision.Feb 27 2021, 7:47 PM
Harbormaster completed remote builds in B37443: Diff 84805.Feb 27 2021, 7:47 PM
rew added a child revision: D28975: autounmountd: set filter-specific flags for the EVFILT_FS event.Feb 27 2021, 7:47 PM
rew added a reviewer: kib.Feb 27 2021, 7:49 PM
kib added inline comments.Feb 27 2021, 11:17 PM
sys/kern/vfs_subr.c
6019

Stylish (kn->kn_sfflags & hint) != 0

6020

But then shouldn't this be

kn->kn_fflags |= kn->kn_sfflags & hint;

?

rew updated this revision to Diff 84835.Feb 28 2021, 9:05 AM

update as noted by kib

Harbormaster completed remote builds in B37453: Diff 84835.Feb 28 2021, 9:06 AM
rew marked an inline comment as done.Feb 28 2021, 9:14 AM
rew added inline comments.
sys/kern/vfs_subr.c
6020

now that you mention it, that does read better..

kib accepted this revision.Feb 28 2021, 5:25 PM
This revision is now accepted and ready to land.Feb 28 2021, 5:25 PM
trasz mentioned this in D28975: autounmountd: set filter-specific flags for the EVFILT_FS event.Mar 2 2021, 7:29 PM
Closed by commit rG0cc746f19352: filt_fsevent: only record interested events (authored by rew). · Explain WhyMar 2 2021, 11:24 PM
This revision was automatically updated to reflect the committed changes.
rew marked an inline comment as done.
rew added a commit: rG0cc746f19352: filt_fsevent: only record interested events.

Revision Contents
Changeset List

PathSize
sys/
kern/
4 lines

Diff 84805

View Options

sys/kern/vfs_subr.c

Loading...