Page MenuHomeFreeBSD
Differential D28975

autounmountd: set filter-specific flags for the EVFILT_FS event
ClosedPublic
Actions

Authored by rew on Feb 27 2021, 7:47 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 4, 2:20 AM
Unknown Object (File)
Mon, Nov 4, 2:19 AM
Unknown Object (File)
Mon, Nov 4, 2:19 AM
Unknown Object (File)
Mon, Nov 4, 1:59 AM
Unknown Object (File)
Thu, Oct 31, 8:49 PM
Unknown Object (File)
Oct 23 2024, 7:26 PM
Unknown Object (File)
Oct 23 2024, 10:33 AM
Unknown Object (File)
Oct 20 2024, 5:43 PM
View All 74 Files
Subscribers
imp

Details

Reviewers
trasz
Commits
rGce22a792deed: autounmountd: set filter-specific flags for the EVFILT_FS filter
Summary

Set the filter-specific flags VQ_MOUNT and VQ_UNMOUNT for the
EVFILT_FS event.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

rew created this revision.Feb 27 2021, 7:47 PM
Herald added a subscriber: imp. · View Herald TranscriptFeb 27 2021, 7:47 PM
rew requested review of this revision.Feb 27 2021, 7:47 PM
rew added a parent revision: D28974: filt_fsevent: only record interested events.
Harbormaster completed remote builds in B37444: Diff 84806.Feb 27 2021, 7:47 PM
rew added a reviewer: trasz.Feb 27 2021, 7:49 PM
trasz added a comment.Mar 2 2021, 6:54 PM

Thank you, but why?

This is more about the commit message than the code itself; I don't remember how kevent works for mount/umount events, and it's not documented in the kqueue(2) man page. In particular, does it fix a bug, or is an API-correctness fix that doesn't change semantics?

trasz accepted this revision.Mar 2 2021, 7:29 PM

Looks like related to D28974, in which case it looks fine.

This revision is now accepted and ready to land.Mar 2 2021, 7:29 PM
rew added a comment.Mar 2 2021, 8:08 PM
In D28975#649731, @trasz wrote:

Looks like related to D28974, in which case it looks fine.

yep, cool - thanks.

D28974 is a bug fix for the EVFILT_FS filter - the bug was that kevents registered for EVFILT_FS were triggered for every EVFILT_FS event, regardless of the fflags specified.

After the fix in D28974, autounmountd wasn't being notified of any kevents (since fflags was 0) - so this review fixes that.

couple other things:

EV_CLEAR could be removed here since it's set by default for EVFILT_FS events - as you know, it doesn't hurt to leave it there though..

noted about the lack of documentation for EVFILT_FS in kqueue(2), will add it to the TODO list..

Closed by commit rGce22a792deed: autounmountd: set filter-specific flags for the EVFILT_FS filter (authored by rew). · Explain WhyMar 2 2021, 11:23 PM
This revision was automatically updated to reflect the committed changes.
rew added a commit: rGce22a792deed: autounmountd: set filter-specific flags for the EVFILT_FS filter.

Revision Contents
Changeset List

PathSize
usr.sbin/
autofs/
2 lines

Diff 85005

View Options

usr.sbin/autofs/autounmountd.c

Loading...