filt_fsevent: only record interested events
ClosedPublic
Actions

Authored by rew on Feb 27 2021, 7:47 PM.

Details

Reviewers

kib

Commits

rG0cc746f19352: filt_fsevent: only record interested events

Summary

Previously, all EVFILT_FS events that were triggered, were also
activated.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

rew created this revision.Feb 27 2021, 7:47 PM

Herald added a subscriber: imp. · View Herald TranscriptFeb 27 2021, 7:47 PM

rew requested review of this revision.Feb 27 2021, 7:47 PM

Harbormaster completed remote builds in B37443: Diff 84805.Feb 27 2021, 7:47 PM

rew added a child revision: D28975: autounmountd: set filter-specific flags for the EVFILT_FS event.Feb 27 2021, 7:47 PM

rew added a reviewer: kib.Feb 27 2021, 7:49 PM

kib added inline comments.Feb 27 2021, 11:17 PM

sys/kern/vfs_subr.c
6019–6020	Stylish `(kn->kn_sfflags & hint) != 0`
6020	But then shouldn't this be kn->kn_fflags \|= kn->kn_sfflags & hint; ?

update as noted by kib

Harbormaster completed remote builds in B37453: Diff 84835.Feb 28 2021, 9:06 AM

rew marked an inline comment as done.Feb 28 2021, 9:14 AM

rew added inline comments.

sys/kern/vfs_subr.c
6020	now that you mention it, that does read better..

kib accepted this revision.Feb 28 2021, 5:25 PM

This revision is now accepted and ready to land.Feb 28 2021, 5:25 PM

trasz mentioned this in D28975: autounmountd: set filter-specific flags for the EVFILT_FS event.Mar 2 2021, 7:29 PM

Closed by commit rG0cc746f19352: filt_fsevent: only record interested events (authored by rew). · Explain WhyMar 2 2021, 11:24 PM

This revision was automatically updated to reflect the committed changes.

rew marked an inline comment as done.

rew added a commit: rG0cc746f19352: filt_fsevent: only record interested events.

Revision Contents
Changeset List

Path

Size

sys/

kern/

vfs_subr.c

3 lines

Diff 85006

View Options

filt_fsevent: only record interested eventsClosedPublicActions