Page MenuHomeFreeBSD
Differential D28781

ports(7): Update instructions for package target
AbandonedPublic
Actions

Authored by debdrup on Feb 18 2021, 9:59 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Aug 8, 7:04 PM
Unknown Object (File)
Fri, Aug 7, 10:10 PM
Unknown Object (File)
Fri, Aug 7, 1:48 PM
Unknown Object (File)
Thu, Aug 6, 9:53 AM
Unknown Object (File)
Thu, Aug 6, 7:24 AM
Unknown Object (File)
Wed, Aug 5, 5:49 AM
Unknown Object (File)
Tue, Jul 28, 10:54 PM
Unknown Object (File)
Mon, Jul 27, 3:39 AM
View All Files
Subscribers
imp
yuripv

Details

Reviewers
rwatson
0mp
linimon
Group Reviewers
manpages
Summary

Packages default to ending up in a different location compared to the
documentation, so catch up to the implemtation by referring to the
location where packages can usually be found if no environment variables
have been set.

While here, also update the mention of the file extension to match the
txz format that packages use.

PR: 253179, 224370
Reported by: rwatson

Test Plan

igor and mandoc -Tlint, neither report issues with what I added.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 37175
Build 34064: arc lint + arc unit

Event Timeline

debdrup created this revision.Feb 18 2021, 9:59 PM
Herald added a subscriber: imp. · View Herald TranscriptFeb 18 2021, 9:59 PM
debdrup requested review of this revision.Feb 18 2021, 9:59 PM
Harbormaster completed remote builds in B37167: Diff 84228.Feb 18 2021, 9:59 PM
debdrup edited the test plan for this revision. (Show Details)Feb 18 2021, 10:00 PM
yuripv added a subscriber: yuripv.Feb 18 2021, 10:17 PM
yuripv added inline comments.
share/man/man7/ports.7
294

This does not seem to be correct, and current working directory is rather ambiguous.

Doing, e.g. make -C /usr/ports/textproc/utf8proc package will put the package to /usr/ports/textproc/utf8proc/work/pkg, and if WRKDIRPREFIX is redefined, the pkg will go there as well, i.e. WRKDIRPREFIX=/usr/obj make -C /usr/ports/textproc/utf8proc package will put the package to /usr/obj/usr/ports/textproc/utf8proc/work/pkg. None of those are related to CWD being e.g. /home/yuripv.

debdrup updated this revision to Diff 84231.Feb 18 2021, 10:27 PM
debdrup marked an inline comment as done.

Address feedback by @yuripv

Harbormaster completed remote builds in B37168: Diff 84231.Feb 18 2021, 10:27 PM
debdrup added inline comments.Feb 18 2021, 10:27 PM
share/man/man7/ports.7
294

I had written something to that effect initially, but convinced myself I remembered wrong.

0mp added inline comments.Feb 19 2021, 12:57 AM
share/man/man7/ports.7
294

The .Pa macro seems appropriate here.

Also, maybe it can be /usr/ports. That would be consistent with the rest of this manual page.

debdrup updated this revision to Diff 84241.Feb 19 2021, 5:06 AM
debdrup marked an inline comment as done.

Address feedback by @0mp

Harbormaster completed remote builds in B37175: Diff 84241.Feb 19 2021, 5:07 AM
debdrup retitled this revision from ports(7): Update instructions to match implementation to ports(7): Update instructions for package target.Feb 19 2021, 5:09 AM
yuripv mentioned this in D28785: ports(7): Fix package path and extension.Feb 19 2021, 11:36 AM
fernape edited the summary of this revision. (Show Details)Feb 19 2021, 11:42 AM
debdrup abandoned this revision.Feb 20 2021, 5:14 AM

I forgot to use the tooling, and missed that the Differential revision field wasn't tagged.

This landed as https://cgit.freebsd.org/src/commit/?id=248a47a4c2fb229ae815fa61875b3f62a2d6856c

Revision Contents
Changeset List

PathSize
share/
man/
man7/
10 lines

Diff 84241

View Options

share/man/man7/ports.7

Loading...