Export various 128 bit long double functions from libgcc_s.so.1
ClosedPublic
Actions

Authored by dim on Feb 15 2021, 7:56 PM.

Details

Reviewers

cem
emaste
jhb

Commits

rGf616d57736dc: Export various 128 bit long double functions from libgcc_s.so.1
rGd552a12be263: Export various 128 bit long double functions from libgcc_s.so.1
rG27693a604a78: Export various 128 bit long double functions from libgcc_s.so.1
rG790a6be5a169: Export various 128 bit long double functions from libgcc_s.so.1

Summary

These were already compiled for some time on aarch64 and riscv, by
including lib/libcompiler_rt/Makefile.inc, but never exported in the
shared library. Since gcc exports these under vesrion GCC_4.6.0, we do
the same.

This review should replace D11482 for now. For e.g. amd64 more work is
still to be done, as compiler-rt does not seem to support 128 bit long
double math for that architecture. (And as far as I know it doesn't have
it at all? But I'm probably missing something.)

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 37033
Build 33922: arc lint + arc unit

Event Timeline

dim created this revision.Feb 15 2021, 7:56 PM

Herald added subscribers: andrew, imp. · View Herald TranscriptFeb 15 2021, 7:56 PM

dim requested review of this revision.Feb 15 2021, 7:56 PM

Harbormaster completed remote builds in B37033: Diff 83957.Feb 15 2021, 7:56 PM

dim mentioned this in D11482: Make compiler-rt's quad-math routines available to libgcc_s.Feb 15 2021, 7:57 PM

cem accepted this revision.Feb 15 2021, 10:14 PM

This revision is now accepted and ready to land.Feb 15 2021, 10:14 PM

Don't the symbol map entries just get ignored if the symbols aren't present, so it would be ok to have these in the MI Symbol.map?

In D28690#642826, @jhb wrote:

Don't the symbol map entries just get ignored if the symbols aren't present, so it would be ok to have these in the MI Symbol.map?

I'm unsure if that is the case. We also have a lib/libgcc_s/arm/Symbol.map, so that's why I copied the approach. But it would simplify things basically back to the old D11482 review, maybe plus or minus one line...

I do think they are ignored if not present, but I don't care strongly either way.

Can someone commit this please?
Thanks in advance!

mark_tranquillussoftware.co.uk added a subscriber: mark_tranquillussoftware.co.uk.Jun 4 2021, 12:14 PM

Closed by commit rG790a6be5a169: Export various 128 bit long double functions from libgcc_s.so.1 (authored by dim). · Explain WhyJun 14 2021, 7:18 PM

This revision was automatically updated to reflect the committed changes.

dim added a commit: rG790a6be5a169: Export various 128 bit long double functions from libgcc_s.so.1.

dim added a commit: rG27693a604a78: Export various 128 bit long double functions from libgcc_s.so.1.Jun 21 2021, 7:12 PM

dim added a commit: rGd552a12be263: Export various 128 bit long double functions from libgcc_s.so.1.

dim added a commit: rGf616d57736dc: Export various 128 bit long double functions from libgcc_s.so.1.