Regenerate flex bootstrap files after 80f31432743446a1e8e4f8cb8268b74ac4e4f2da
Details
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 36919 Build 33808: arc lint + arc unit
Event Timeline
There is no need to change bootstrap requirement because the old lex can build head just fine AFAICT. Although it's nice to update the generated files, I don't see any functional changes between two.
Also, 0 -> NULL changes were not mine.
The built lex works just fine, and is functionally the same. I did this for reproducibility, lex built from old lex is not binary identical to one built from new lex. This is one change of many I have in my queue to have binary identical output of make buildworld and buildkernel, no matter the host.
Also, 0 -> NULL changes were not mine.
Good to know about that. This is literally me just regenerating the files, so I'll maintain the NULL check style.
I still don't like to change the bootstrap requirement. Other than that, it looks good to me.
That's fair. In the general case I suppose people won't care, and if a person wants to guarantee a reproducible build they can force the bootstrap tools.
if a person wants to guarantee a reproducible build they can force the bootstrap tools.
Exactly.
BTW, initparse.c and initparse.h were generated with yacc. Therefore, it is technically "regen after byacc 20200330 (r363170)".
Right! I've been sitting on this for the better part of a year, and my original commit message was 'update flex'.. not exactly helpful for making a quality commit message when submitting upstream ;)
Yeah, just saw those. I'll also regen the init files after those changes and see if there are differences. That'll be in a few hours though.
Please regen initskel.c because flex.skl was updated in 6b7e592c215fb76ea027f25030ddc9a697184fbe. Note it was also MFC'ed to stable/13 and releng/13.0.