Page MenuHomeFreeBSD

pkg(7): address minor nits (mostly clang-analyze complaints)
ClosedPublic

Authored by kevans on Feb 7 2021, 6:58 PM.
Tags
None
Referenced Files
F160557995: D28525.diff
Thu, Jun 25, 4:13 PM
Unknown Object (File)
Tue, Jun 23, 7:46 PM
Unknown Object (File)
Mon, Jun 22, 3:09 AM
Unknown Object (File)
Thu, Jun 18, 9:32 PM
Unknown Object (File)
May 25 2026, 7:26 PM
Unknown Object (File)
May 25 2026, 7:18 PM
Unknown Object (File)
May 18 2026, 10:30 PM
Unknown Object (File)
May 18 2026, 10:24 PM
Subscribers

Details

Summary
  • One (1) spurious whitespace.
  • One (1) occurrence of "random(3) bad, arc4random(3)" good.
  • Three (3) writes that will never be seen.

The latter two points are complaints from clang-analyze. Switching to
arc4random(3) is decidedly a good idea because we weren't doing any kind
of PRNG seeding anyways. The discarded assignments are arguably good
for future-proofing, but it's better to improve the S/N ratio from
clang-analyze.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 36783
Build 33672: arc lint + arc unit