Page MenuHomeFreeBSD

pkg(7): address minor nits (mostly clang-analyze complaints)
ClosedPublic

Authored by kevans on Feb 7 2021, 6:58 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jul 5, 5:29 PM
Unknown Object (File)
Sat, Jun 22, 12:34 AM
Unknown Object (File)
May 4 2024, 7:24 PM
Unknown Object (File)
May 2 2024, 3:30 PM
Unknown Object (File)
Mar 12 2024, 10:00 AM
Unknown Object (File)
Mar 12 2024, 10:00 AM
Unknown Object (File)
Mar 12 2024, 9:56 AM
Unknown Object (File)
Mar 8 2024, 5:37 AM
Subscribers

Details

Summary
  • One (1) spurious whitespace.
  • One (1) occurrence of "random(3) bad, arc4random(3)" good.
  • Three (3) writes that will never be seen.

The latter two points are complaints from clang-analyze. Switching to
arc4random(3) is decidedly a good idea because we weren't doing any kind
of PRNG seeding anyways. The discarded assignments are arguably good
for future-proofing, but it's better to improve the S/N ratio from
clang-analyze.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable